Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STCOR-863 Skip link text should announce its destination rather than what it's skipping. #1495

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

JohnC-80
Copy link
Contributor

STCOR-863

The previous text: "Skip Main Navigation" vs the forward-looking message "Skip to main content" makes AT users aware of where their focus will be placed when following the link. This only involved changing the translation string.

@JohnC-80 JohnC-80 requested a review from zburke June 18, 2024 20:19
Copy link

github-actions bot commented Jun 18, 2024

Jest Unit Test Results

  1 files  ±0   39 suites  ±0   49s ⏱️ -1s
291 tests ±0  291 ✅ ±0  0 💤 ±0  0 ❌ ±0 
292 runs  ±0  292 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5bc6309. ± Comparison against base commit 2bb7586.

♻️ This comment has been updated with latest results.

Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to remember to check that translations have been updated with new values before the next release.

Copy link

github-actions bot commented Jul 2, 2024

Bigtest Unit Test Results

193 tests  ±0   188 ✅ ±0   6s ⏱️ ±0s
  1 suites ±0     5 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 5bc6309. ± Comparison against base commit 2bb7586.

This pull request removes 5 and adds 3 tests. Note that renamed tests count towards both.
      equal to check email label in english translation
      equal to check email precautions label in english translation
      equal to sent email precautions label in english translation
Chrome_126_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the header with an appropriate text content
Chrome_126_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the paragraph with an appropriate text content
Chrome_126_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the header with an appropriate text content
      equal to check email label in english translation
Chrome_126_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the paragraph with an appropriate text content
      equal to check email precautions label in english translation
Chrome_126_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the paragraph with an appropriate text content
      equal to sent email precautions label in english translation

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented Jul 2, 2024

@JohnC-80 JohnC-80 merged commit 69dcdd5 into master Jul 2, 2024
26 checks passed
@JohnC-80 JohnC-80 deleted the STCOR-863 branch July 2, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants