Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STCOR-880 (STCOR-869 backport) add margin to prevent cookie expiration #1529

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

zburke
Copy link
Member

@zburke zburke commented Sep 5, 2024

Add a small margin to the /authn/logout call to ensure it is called before the cookie expires.

See PR #1513

Refs STCOR-880, STCOR-869

ryandberger and others added 2 commits September 5, 2024 17:03
…e expires (#1513)

* Added a small time margin to wait so that cookie is not deleted before /logout request

* Fix test and lint issue

(cherry picked from commit da01a6a)
Add a small margin to the `/authn/logout` call to ensure it is called
before the cookie expires.

See PR #1513

Refs STCOR-880, STCOR-869

This comment has been minimized.

Copy link

github-actions bot commented Sep 6, 2024

Jest Unit Test Statistics

240 tests  ±0   240 ✔️ ±0   52s ⏱️ +2s
  45 suites ±0       0 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 7844315. ± Comparison against base commit 9038661.

This comment has been minimized.

Copy link

github-actions bot commented Sep 6, 2024

BigTest Unit Test Statistics

    1 files  ±0      1 suites  ±0   9s ⏱️ -1s
266 tests ±0  260 ✔️ ±0  6 💤 ±0  0 ±0 
269 runs  ±0  263 ✔️ ±0  6 💤 ±0  0 ±0 

Results for commit 7844315. ± Comparison against base commit 9038661.

Copy link

sonarcloud bot commented Sep 6, 2024

@zburke zburke merged commit 3aef1a0 into keycloak-quesnelia Sep 6, 2024
6 checks passed
@zburke zburke deleted the STCOR-880 branch September 6, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants