Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STCOR-885] Clear saved entry path so that subsequent logins will use default base URL. #1531

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

ryandberger
Copy link
Member

@ryandberger ryandberger commented Sep 6, 2024

  • Fixes STCOR-885.
  • The issue was that if a user initially navigated to a routed URL such as /users?search=test after redirect on login, that route is opened on all consecutive logins. By clearing session storage after reading and redirecting, subsequent logins go to the default / route as expected.
  • Cleaned up some redundant code. setUnauthorizedPathToSession() was being called with same params as it defaults to. Also cleaned up duplicate code within setUnauthorizedPathToSession()

Copy link

github-actions bot commented Sep 6, 2024

Jest Unit Test Results

279 tests  ±0   279 ✅ ±0   59s ⏱️ -2s
 54 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 6aa90cd. ± Comparison against base commit d3f2c20.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Sep 6, 2024

Bigtest Unit Test Results

192 tests  ±0   187 ✅ ±0   6s ⏱️ ±0s
  1 suites ±0     5 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 6aa90cd. ± Comparison against base commit d3f2c20.

♻️ This comment has been updated with latest results.

Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, this resolves the problem described in STCOR-885, but it also reintroduces those like STCOR-849. We need to resolve both.

src/loginServices.js Outdated Show resolved Hide resolved
@ryandberger
Copy link
Member Author

Technically, this resolves the problem described in STCOR-885, but it also reintroduces those like STCOR-849. We need to resolve both.

Moved removeUnauthorizedPathFromSession() to OIDCRedirect.js so the value is cleared right after being used rather than on logout. Please re-review.

Copy link

sonarcloud bot commented Sep 9, 2024

Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please update the PR description/commit commit to reflect the actual changes that we settled on in this final version.

@ryandberger ryandberger merged commit f694821 into keycloak-ramsons Sep 9, 2024
26 checks passed
@ryandberger ryandberger deleted the STCOR-885 branch September 9, 2024 19:13
ryandberger added a commit that referenced this pull request Sep 10, 2024
… default base URL. (#1531)

* Clear saved entry path so that subsequent logins will use default base URL

* Moving removeUnauthorizedPathFromSession() to OIDCRedirect so the value is cleared right after being used rather than on logout

* Add comment

(cherry picked from commit f694821)
zburke added a commit that referenced this pull request Sep 20, 2024
The time has come. The time is now. 
`keycloak-eureka` will you please merge now!
You can go in a merge commit. You can squash with ease.
You can go in a rebase. But please merge. Please!

* STCOR-773 #1385: Handle Eureka-based discovery
* #1388: handle absent `provides` property on interfaces in Settings > About
* STCOR-790 #1389: Pass client-id from stripes-config to keycloak
* STCOR-794 #1400: Reset pre-login tenant-selection form when navigating back to it
* STCOR-795 #1399: When `users-keycloak` interface is present, use its API for password-reset
* STCOR-796 #1410: replace x-okapi-token credentials with RTR and cookies
* STCOR-811 #1417: retrieve AT/RT expiration data from `/authn/token` response
* STCOR-812 #1416: include `X-Okapi-Tenant` header in call to `/authn/logout`
* STCOR-813 #1421: correctly parse `.../_self` permissions
* STCOR-810 #1418 #1427 #1429: leverage `stripes-config::config.tenantOptions` in place of deprecated tenant-entitlement values
* STCOR-803 #1426: logout immediately, without confirming or redirecting through keycloak
* STCOR-816 #1432: only call `/saml/check` when `login-saml` interface is present
* STCOR-789 #1442: restore original URL after login
* STCOR-820 #1445: optionally retrieve password-reset token from path (or query-string)
* STCOR-845 #1462: correctly handle redirect after password-change
* STCOR-787 #1487 #1492: retrieve clientId and tenant from stripes-config::config.tenantOptions
* STCOR-859 #1489: correctly list UI apps under apps/modules/interfaces column of Settings > About
* STCOR-776 #1490: show idle-session modal with countdown timer before logout
* STCOR-864 #1498: correctly evaluate `typeof stripes.okapi`
* STCOR-865 #1500: call `logout()` exclusively from `/logout*` routes
* STCOR-834 #1491`: refactor `useUserTenantPermissions` to switch on `roles` interface presence
* STCOR-866 #1502: include `/users-keycloak/_self` in list of authentication-related endpoints
* STCOR-867 #1505 #1506: store permission displaynames in redux
* STCOR-862 #1503: handle fixed-length-session timeout
* STCOR-869 #1513: avoid storing `/logout*` as a return-to URL; ensure `/logout` is called with a valid token
* STCOR-872 #1520: return query-keys from `useChunkedCQLFetch()`
* STCOR-874 #1521: provide `key` to `<SessionEventContainer>` components
* STCOR-873 #1519: `useChunkedCQLFetch()` should use `tenantId` argument when present
* STCOR-876 #1526: restore original URL after login (regression of STCOR-789)
* STCOR-885 #1531: clear original URL from storage after login-and-redirect
* STCOR-889 #1536: include all reference interfaces in optionalOkapiInterfaces

I said MERGE and MERGE I meant....
The time had come ... so this branch went.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants