Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STCOR-883: fixed-length session timeout banner may scroll off-screen or otherwise be hidden #1540

Merged
merged 7 commits into from
Oct 9, 2024

Conversation

aidynoJ
Copy link
Contributor

@aidynoJ aidynoJ commented Oct 2, 2024

Purpose:
STCOR-883 - fixed-length session timeout banner may scroll off-screen or otherwise be hidden.
Approach:
Place session timeout banner at the bottom of the page.

Screenshot 2024-10-02 at 15 59 40
Screenshot 2024-10-02 at 16 00 05
Screenshot 2024-10-09 at 20 33 15

Copy link

github-actions bot commented Oct 2, 2024

Jest Unit Test Results

  1 files  ±0   56 suites  ±0   1m 0s ⏱️ ±0s
339 tests ±0  339 ✅ ±0  0 💤 ±0  0 ❌ ±0 
343 runs  ±0  343 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c44a934. ± Comparison against base commit 0cdfe80.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 2, 2024

Bigtest Unit Test Results

192 tests  ±0   187 ✅ ±0   6s ⏱️ ±0s
  1 suites ±0     5 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit c44a934. ± Comparison against base commit 0cdfe80.

This pull request removes 5 and adds 3 tests. Note that renamed tests count towards both.
      equal to check email label in english translation
      equal to check email precautions label in english translation
      equal to sent email precautions label in english translation
Chrome_129_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the header with an appropriate text content
Chrome_129_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the paragraph with an appropriate text content
Chrome_129_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the header with an appropriate text content
      equal to check email label in english translation
Chrome_129_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the paragraph with an appropriate text content
      equal to check email precautions label in english translation
Chrome_129_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the paragraph with an appropriate text content
      equal to sent email precautions label in english translation

♻️ This comment has been updated with latest results.

Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we leverage OverlayContainer instead of creating our own?

Lint is cranky.

CHANGELOG.md Outdated Show resolved Hide resolved
src/App.js Outdated Show resolved Hide resolved
src/RootWithIntl.js Outdated Show resolved Hide resolved
src/RootWithIntl.js Outdated Show resolved Hide resolved
@aidynoJ
Copy link
Contributor Author

aidynoJ commented Oct 4, 2024

Can we leverage OverlayContainer instead of creating our own?

Lint is cranky.

I have changed the approach a bit. Moved createPortal to the SessionContainer itself and teleport happens into the document.body, removed events-portal and related styles.
Lint is still cranky. I run yarn lint --fix before each commit. But it doesn't fix formatting that was automatically applied by the auto formatting on save in IDE (JB Webstorm), I'm looking into that.

@aidynoJ aidynoJ requested a review from zburke October 4, 2024 08:08
@aidynoJ aidynoJ marked this pull request as draft October 7, 2024 06:54
@aidynoJ aidynoJ marked this pull request as ready for review October 9, 2024 15:34
Copy link

sonarcloud bot commented Oct 9, 2024

@aidynoJ aidynoJ merged commit 9f28052 into master Oct 9, 2024
26 checks passed
@aidynoJ aidynoJ deleted the STCOR-883 branch October 9, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants