-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STCOR-883: fixed-length session timeout banner may scroll off-screen or otherwise be hidden #1540
Conversation
Bigtest Unit Test Results192 tests ±0 187 ✅ ±0 6s ⏱️ ±0s Results for commit c44a934. ± Comparison against base commit 0cdfe80. This pull request removes 5 and adds 3 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we leverage OverlayContainer instead of creating our own?
Lint is cranky.
I have changed the approach a bit. Moved createPortal to the SessionContainer itself and teleport happens into the document.body, removed events-portal and related styles. |
Quality Gate passedIssues Measures |
Purpose:
STCOR-883 - fixed-length session timeout banner may scroll off-screen or otherwise be hidden.
Approach:
Place session timeout banner at the bottom of the page.