Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STRIPES-820: Trying out stripes-ui #1841

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

STRIPES-820: Trying out stripes-ui #1841

wants to merge 1 commit into from

Conversation

mkuklis
Copy link
Contributor

@mkuklis mkuklis commented Nov 9, 2022

Purpose

Approach

TODOS and Open Questions

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Jest Unit Test Statistics

    1 files  ±    0    48 suites   - 26   1m 3s ⏱️ - 2m 3s
136 tests  - 105  136 ✔️  - 105  0 💤 ±0  0 ±0 
139 runs   - 106  139 ✔️  - 106  0 💤 ±0  0 ±0 

Results for commit a448c2a. ± Comparison against base commit ed9d7e8.

This pull request removes 105 tests.
BrowseInventory should call "changeSearch" when search query was changed ‑ BrowseInventory should call "changeSearch" when search query was changed
BrowseInventory should call "changeSearchIndex" when browse mode option was changed ‑ BrowseInventory should call "changeSearchIndex" when browse mode option was changed
BrowseInventory should not call "changeSearch" when search query is not valid ‑ BrowseInventory should not call "changeSearch" when search query is not valid
BrowseInventory should render browse filters and results panes ‑ BrowseInventory should render browse filters and results panes
BrowseInventoryFilters should call "applyFilters" when clear button was clicked for facet acccordion ‑ BrowseInventoryFilters should call "applyFilters" when clear button was clicked for facet acccordion
BrowseInventoryFilters should call "applyFilters" when facet filter was applied ‑ BrowseInventoryFilters should call "applyFilters" when facet filter was applied
BrowseInventoryFilters should render filters for inventory browse ‑ BrowseInventoryFilters should render filters for inventory browse
BrowseResultsList should navigate to instance Search page and show related instances ‑ BrowseResultsList should navigate to instance Search page and show related instances
BrowseResultsList should render browse data ‑ BrowseResultsList should render browse data
BrowseResultsPane should render browse results pane ‑ BrowseResultsPane should render browse results pane
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit a448c2a. ± Comparison against base commit ed9d7e8.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant