Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIIN-3173: Instance: Display all versions in View history fourth pane #2756

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
* Update Inventory: Set records for deletion permission's effect on ‘Set for deletion’ checkbox in Instance Edit view. Refs UIIN-3260.
* *BREAKING* Migrate stripes dependencies to their Sunflower versions. Refs UIIN-3223.
* *BREAKING* Migrate `react-intl` to v7. Refs UIIN-3224.
* Instance: Display all versions in View history fourth pane. Refs UIIN-3173.

## [12.0.12](https://github.com/folio-org/ui-inventory/tree/v12.0.12) (2025-01-27)
[Full Changelog](https://github.com/folio-org/ui-inventory/compare/v12.0.11...v12.0.12)
Expand Down
8 changes: 5 additions & 3 deletions src/Instance/InstanceDetails/InstanceDetails.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,12 @@ import { InstanceClassificationView } from './InstanceClassificationView';
import { InstanceRelationshipView } from './InstanceRelationshipView';
import { InstanceNewHolding } from './InstanceNewHolding';
import { InstanceAcquisition } from './InstanceAcquisition';
import HelperApp from '../../components/HelperApp';
import { VersionHistory } from '../../views/VersionHistory';

import HelperApp from '../../components/HelperApp';
import { DataContext } from '../../contexts';
import { ConsortialHoldings } from '../HoldingsList/consortium/ConsortialHoldings';
import { InstanceVersionHistory } from '../InstanceVersionHistory';

import {
getAccordionState,
getPublishingInfo,
Expand Down Expand Up @@ -352,7 +353,8 @@ const InstanceDetails = forwardRef(({
</AccordionStatus>
</Pane>
{isVersionHistoryOpen && (
<VersionHistory
<InstanceVersionHistory
instanceId={instance?.id}
onClose={() => setIsVersionHistoryOpen(false)}
/>
)}
Expand Down
132 changes: 132 additions & 0 deletions src/Instance/InstanceVersionHistory/InstanceVersionHistory.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,132 @@
import {
useContext,
useState,
} from 'react';
import { useIntl } from 'react-intl';
import PropTypes from 'prop-types';

import {
AuditLogPane,
NoValue,
} from '@folio/stripes/components';

import { DataContext } from '../../contexts';
import {
useInstanceAuditDataQuery,
useVersionHistory,
} from '../../hooks';

import { getDateWithTime } from '../../utils';

const InstanceVersionHistory = ({
instanceId,
onClose,
}) => {
const intl = useIntl();
const { formatMessage } = intl;

const referenceData = useContext(DataContext);

const [lastVersionEventTs, setLastVersionEventTs] = useState(null);

const {
data,
totalRecords,
isLoading,
} = useInstanceAuditDataQuery(instanceId, lastVersionEventTs);

const {
actionsMap,
isLoadedMoreVisible,
versionsToDisplay,
} = useVersionHistory(data, totalRecords);

const fieldLabelsMap = {
administrativeNotes: formatMessage({ id: 'ui-inventory.administrativeNotes' }),
alternativeTitles: formatMessage({ id: 'ui-inventory.alternativeTitles' }),
catalogedDate: formatMessage({ id: 'ui-inventory.catalogedDate' }),
childInstances: formatMessage({ id: 'ui-inventory.childInstances' }),
classifications: formatMessage({ id: 'ui-inventory.classifications' }),
contributors: formatMessage({ id: 'ui-inventory.contributors' }),
date1: formatMessage({ id: 'ui-inventory.date1' }),
date2: formatMessage({ id: 'ui-inventory.date2' }),
dateTypeId: formatMessage({ id: 'ui-inventory.dateType' }),
deleted: formatMessage({ id: 'ui-inventory.setForDeletion' }),
discoverySuppress: formatMessage({ id: 'ui-inventory.discoverySuppressed' }),
editions: formatMessage({ id: 'ui-inventory.edition' }),
electronicAccess: formatMessage({ id: 'ui-inventory.electronicAccess' }),
hrid: formatMessage({ id: 'ui-inventory.instanceHrid' }),
identifiers: formatMessage({ id: 'ui-inventory.identifiers' }),
instanceFormatIds: formatMessage({ id: 'ui-inventory.instanceFormats' }),
instanceTypeId: formatMessage({ id: 'ui-inventory.resourceType' }),
indexTitle: formatMessage({ id: 'ui-inventory.indexTitle' }),
languages: formatMessage({ id: 'ui-inventory.languages' }),
modeOfIssuanceId: formatMessage({ id: 'ui-inventory.modeOfIssuance' }),
natureOfContentTermIds: formatMessage({ id: 'ui-inventory.natureOfContentTerms' }),
notes: formatMessage({ id: 'ui-inventory.instanceNotes' }),
parentInstances: formatMessage({ id: 'ui-inventory.parentInstances' }),
physicalDescriptions: formatMessage({ id: 'ui-inventory.physicalDescriptions' }),
precedingTitles: formatMessage({ id: 'ui-inventory.precedingTitles' }),
previouslyHeld: formatMessage({ id: 'ui-inventory.previouslyHeld' }),
publication: formatMessage({ id: 'ui-inventory.publications' }),
publicationFrequency: formatMessage({ id: 'ui-inventory.publicationFrequency' }),
publicationRange: formatMessage({ id: 'ui-inventory.publicationRange' }),
series: formatMessage({ id: 'ui-inventory.seriesStatements' }),
source: formatMessage({ id: 'ui-inventory.source' }),
staffSuppress: formatMessage({ id: 'ui-inventory.staffSuppressed' }),
statisticalCodeIds: formatMessage({ id: 'ui-inventory.statisticalCodes' }),
statusId: formatMessage({ id: 'ui-inventory.instanceStatus' }),
statusUpdatedDate: formatMessage({ id: 'ui-inventory.instanceStatusUpdatedDate' }),
subjects: formatMessage({ id: 'ui-inventory.subjects' }),
succeedingTitles: formatMessage({ id: 'ui-inventory.succeedingTitles' }),
tagList: formatMessage({ id: 'stripes-smart-components.tags' }),
title: formatMessage({ id: 'ui-inventory.instances.columns.title' }),
};
const fieldFormatter = {
alternativeTitleTypeId: value => referenceData.alternativeTitleTypes?.find(type => type.id === value)?.name,
classificationTypeId: value => referenceData.classificationTypes?.find(type => type.id === value)?.name,
contributorNameTypeId: value => referenceData.contributorNameTypes?.find(contributor => contributor.id === value)?.name,
contributorTypeId: value => referenceData.contributorTypes?.find(contributor => contributor.id === value)?.name,
contributorTypeText: value => value || <NoValue />,
dateTypeId: value => referenceData.instanceDateTypes?.find(type => type.id === value)?.name,
identifierTypeId: value => referenceData.identifierTypes?.find(type => type.id === value)?.name,
instanceFormatIds: value => referenceData.instanceFormats?.find(format => format.id === value)?.name,
instanceNoteTypeId: value => referenceData.instanceNoteTypes?.find(note => note.id === value)?.name,
instanceTypeId: value => referenceData.instanceTypes?.find(type => type.id === value)?.name,
modeOfIssuanceId: value => referenceData.modesOfIssuance?.find(mode => mode.id === value)?.name,
natureOfContentTermIds: value => referenceData.natureOfContentTerms?.find(term => term.id === value)?.name,
primary: value => value.toString(),
relationshipId: value => referenceData.electronicAccessRelationships?.find(rel => rel.id === value)?.name,
sourceId: value => referenceData.subjectSources?.find(source => source.id === value)?.name,
staffOnly: value => value.toString(),
statisticalCodeIds: value => referenceData.statisticalCodes?.find(code => code.id === value)?.name,
statusId: value => referenceData.instanceStatuses?.find(status => status.id === value)?.name,
statusUpdatedDate: value => getDateWithTime(value),
typeId: value => referenceData.subjectTypes?.find(type => type.id === value)?.name,
uri: value => value || <NoValue />,
};

const handleLoadMore = lastEventTs => {
setLastVersionEventTs(lastEventTs);
};

return (
<AuditLogPane
versions={versionsToDisplay}
onClose={onClose}
isLoadedMoreVisible={isLoadedMoreVisible}
handleLoadMore={handleLoadMore}
isLoading={isLoading}
fieldLabelsMap={fieldLabelsMap}
fieldFormatter={fieldFormatter}
actionsMap={actionsMap}
/>
);
};

InstanceVersionHistory.propTypes = {
instanceId: PropTypes.string.isRequired,
onClose: PropTypes.func,
};

export default InstanceVersionHistory;
65 changes: 65 additions & 0 deletions src/Instance/InstanceVersionHistory/InstanceVersionHistory.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
import {
QueryClient,
QueryClientProvider,
} from 'react-query';
import { screen } from '@folio/jest-config-stripes/testing-library/react';

import {
renderWithIntl,
translationsProperties,
} from '../../../test/jest/helpers';

import InstanceVersionHistory from './InstanceVersionHistory';
import { DataContext } from '../../contexts';

jest.mock('../../hooks', () => ({
...jest.requireActual('../../hooks'),
useInstanceAuditDataQuery: () => jest.fn(),
}));

const queryClient = new QueryClient();

const onCloseMock = jest.fn();
const instanceId = 'instanceId';
const mockReferenceData = {
alternativeTitleTypes: [],
classificationTypes: [],
contributorNameTypes: [],
contributorTypes: [],
instanceDateTypes: [],
identifierTypes: [],
instanceFormats: [],
instanceNoteTypes: [],
instanceTypes: [],
modesOfIssuance: [],
natureOfContentTerms: [],
electronicAccessRelationships: [],
subjectSources: [],
statisticalCodes: [],
instanceStatuses: [],
subjectTypes:[],
};

const renderInstanceVersionHistory = () => {
const component = (
<QueryClientProvider client={queryClient}>
<DataContext.Provider value={mockReferenceData}>
<InstanceVersionHistory
instanceId={instanceId}
onClose={onCloseMock}
/>
</DataContext.Provider>
</QueryClientProvider>
);

return renderWithIntl(component, translationsProperties);
};

describe('InstanceVersionHistory', () => {
it('should render View history pane', () => {
renderInstanceVersionHistory();

expect(screen.getByText('Version history')).toBeInTheDocument();
});
});

1 change: 1 addition & 0 deletions src/Instance/InstanceVersionHistory/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export { default as InstanceVersionHistory } from './InstanceVersionHistory';
2 changes: 2 additions & 0 deletions src/hooks/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ export { default as useCallout } from './useCallout';
export { default as useHoldingItemsQuery } from './useHoldingItemsQuery';
export { default as useHoldingMutation } from './useHoldingMutation';
export { default as useHoldingsFromStorage } from './useHoldingsFromStorage';
export { default as useInstanceAuditDataQuery } from './useInstanceAuditDataQuery';
export { default as useInstanceMutation } from './useInstanceMutation';
export { default as useHoldingsQueryByHrids } from './useHoldingsQueryByHrids';
export { default as useInventoryBrowse } from './useInventoryBrowse';
Expand All @@ -14,6 +15,7 @@ export { default as useClassificationIdentifierTypes } from './useClassification
export { default as useClassificationBrowseConfig } from './useClassificationBrowseConfig';
export { default as useUpdateOwnership } from './useUpdateOwnership';
export { default as useLocalStorageItems } from './useLocalStorageItems';
export { default as useVersionHistory } from './useVersionHistory';
export * from './useQuickExport';
export * from '@folio/stripes-inventory-components/lib/queries/useInstanceDateTypes';
export * from './useCallNumberTypesQuery';
Expand Down
1 change: 1 addition & 0 deletions src/hooks/useInstanceAuditDataQuery/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export { default } from './useInstanceAuditDataQuery';
30 changes: 30 additions & 0 deletions src/hooks/useInstanceAuditDataQuery/useInstanceAuditDataQuery.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
import { useQuery } from 'react-query';

import {
useNamespace,
useOkapiKy,
} from '@folio/stripes/core';

const useInstanceAuditDataQuery = (instanceId, eventTs) => {
const ky = useOkapiKy();
const [namespace] = useNamespace({ key: 'instance-audit-data' });

// eventTs param is used to load more data
const { isLoading, data = {} } = useQuery({
queryKey: [namespace, instanceId, eventTs],
queryFn: () => ky.get(`audit-data/inventory/instance/${instanceId}`, {
searchParams: {
...(eventTs && { eventTs })
}
}).json(),
enabled: Boolean(instanceId),
});

return {
data: data?.inventoryAuditItems || [],
totalRecords: data?.totalRecords,
isLoading,
};
};

export default useInstanceAuditDataQuery;
12 changes: 12 additions & 0 deletions src/hooks/useVersionHistory/getActionLabel.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
/**
* Gets translated change type label
* @param {function} formatMessage
* @returns {{ADDED, MODIFIED, REMOVED}}
*/
export const getActionLabel = formatMessage => {
return {
ADDED: formatMessage({ id: 'stripes-acq-components.audit-log.action.added' }),
MODIFIED: formatMessage({ id: 'stripes-acq-components.audit-log.action.edited' }),
REMOVED: formatMessage({ id: 'stripes-acq-components.audit-log.action.removed' }),
};
};
15 changes: 15 additions & 0 deletions src/hooks/useVersionHistory/getActionLabel.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import { getActionLabel } from './getActionLabel';

const intl = { formatMessage: ({ id }) => id };

describe('getActionLabel', () => {
it('should return correct action labels', () => {
const labels = {
ADDED: 'stripes-acq-components.audit-log.action.added',
MODIFIED: 'stripes-acq-components.audit-log.action.edited',
REMOVED: 'stripes-acq-components.audit-log.action.removed',
};

expect(getActionLabel(intl.formatMessage)).toEqual(labels);
});
});
28 changes: 28 additions & 0 deletions src/hooks/useVersionHistory/getChangedFieldsList.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import { sortBy } from 'lodash';

/**
* Merge fieldChanges and collectionChanges into a list of changed fields and sort by changeType
* @param {Object} diff
* @param {Array} diff.fieldChanges
* @param {Array} diff.collectionChanges
* @returns {Array.<{fieldName: String, changeType: String, newValue: any, oldValue: any}>}
*/
export const getChangedFieldsList = diff => {
const fieldChanges = diff.fieldChanges ? diff.fieldChanges.map(field => ({
fieldName: field.fieldName,
changeType: field.changeType,
newValue: field.newValue,
oldValue: field.oldValue,
})) : [];

const collectionChanges = diff.collectionChanges ? diff.collectionChanges.flatMap(collection => {
return collection.itemChanges.map(field => ({
fieldName: collection.collectionName,
changeType: field.changeType,
newValue: field.newValue,
oldValue: field.oldValue,
}));
}) : [];

return sortBy([...fieldChanges, ...collectionChanges], data => data.changeType);
};
1 change: 1 addition & 0 deletions src/hooks/useVersionHistory/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export { default } from './useVersionHistory';
Loading
Loading