-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UINV-553: Display selected version in Invoice line view #830
Conversation
data, | ||
isLoading, | ||
refetch, | ||
} = useQuery( | ||
[namespace, invoiceLineId], | ||
() => ky.get(`${INVOICE_LINE_API}/${invoiceLineId}`).json(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
() => ky.get(`${INVOICE_LINE_API}/${invoiceLineId}`).json(), | |
({ signal }) => ky.get(`${INVOICE_LINE_API}/${invoiceLineId}`, { signal }).json(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we have https://github.com/folio-org/stripes-acq-components/blob/master/lib/hooks/useOrderLine/useOrderLine.js probably we can get rid off this local implementation of hook
Jest Unit Test Statistics 1 files ±0 125 suites +3 3m 37s ⏱️ -1s Results for commit fabad03. ± Comparison against base commit 55abd79. This pull request removes 3 and adds 7 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Quality Gate passedIssues Measures |
Purpose
UINV-553: Display selected version in Invoice line view
Approach
Screen.Recording.2024-11-22.at.18.50.48.mp4
Screenshots
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.