Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UINV-553: Display selected version in Invoice line view #830

Merged
merged 7 commits into from
Nov 24, 2024

Conversation

alisher-epam
Copy link
Contributor

Purpose

UINV-553: Display selected version in Invoice line view

Approach

Screen.Recording.2024-11-22.at.18.50.48.mp4

Screenshots

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@alisher-epam alisher-epam self-assigned this Nov 22, 2024
@alisher-epam alisher-epam requested review from usavkov-epam and a team November 22, 2024 14:00
Copy link

github-actions bot commented Nov 22, 2024

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit fabad03. ± Comparison against base commit 55abd79.

♻️ This comment has been updated with latest results.

data,
isLoading,
refetch,
} = useQuery(
[namespace, invoiceLineId],
() => ky.get(`${INVOICE_LINE_API}/${invoiceLineId}`).json(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
() => ky.get(`${INVOICE_LINE_API}/${invoiceLineId}`).json(),
({ signal }) => ky.get(`${INVOICE_LINE_API}/${invoiceLineId}`, { signal }).json(),

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have https://github.com/folio-org/stripes-acq-components/blob/master/lib/hooks/useOrderLine/useOrderLine.js probably we can get rid off this local implementation of hook

Copy link

github-actions bot commented Nov 22, 2024

Jest Unit Test Statistics

    1 files  ±0  125 suites  +3   3m 37s ⏱️ -1s
381 tests +4  381 ✔️ +4  0 💤 ±0  0 ±0 
387 runs  +5  387 ✔️ +5  0 💤 ±0  0 ±0 

Results for commit fabad03. ± Comparison against base commit 55abd79.

This pull request removes 3 and adds 7 tests. Note that renamed tests count towards both.
useOrderLine should return order line ‑ useOrderLine should return order line
useOrdersByPoNumbers should display adjustments and poLines ‑ useOrdersByPoNumbers should display adjustments and poLines
useOrdersByPoNumbers should render component ‑ useOrdersByPoNumbers should render component
InvoiceLineVersionHistory should close version view when 'Version close' button was clicked ‑ InvoiceLineVersionHistory should close version view when 'Version close' button was clicked
InvoiceLineVersionHistory should display Invoice version details ‑ InvoiceLineVersionHistory should display Invoice version details
VersionHistoryView should display adjustments and fundDistributions ‑ VersionHistoryView should display adjustments and fundDistributions
VersionHistoryView should display adjustments and poLines ‑ VersionHistoryView should display adjustments and poLines
VersionHistoryView should render component ‑ VersionHistoryView should render component
useInvoiceLineVersions should return invoice versions ‑ useInvoiceLineVersions should return invoice versions
useSelectedInvoiceLineVersion should return Invoice version data ‑ useSelectedInvoiceLineVersion should return Invoice version data

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented Nov 24, 2024

@alisher-epam alisher-epam merged commit be5f559 into master Nov 24, 2024
6 checks passed
@alisher-epam alisher-epam deleted the UINV-553 branch November 24, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants