Respect useTypoMetrics
#306
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 26, 2023 20:50
Signed-off-by: Vsevolod Volkov <[email protected]>
Signed-off-by: Vsevolod Volkov <[email protected]>
Signed-off-by: Vsevolod Volkov <[email protected]>
added 2 commits
April 10, 2023 16:32
Signed-off-by: Vsevolod Volkov <[email protected]>
Signed-off-by: Vsevolod Volkov <[email protected]>
StLyn4
force-pushed
the
respect-useTypoMetrics
branch
from
c8ba19c
to
dad5cca
Compare
ptoussai
reviewed
Nov 19, 2024
ptoussai
added a commit
to lineto/fontkit
that referenced
this pull request
Nov 19, 2024
Fix issue with foliojs#306
Signed-off-by: Vsevolod Volkov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also contains the changes contained in
vheaandglyffixes #305 so that you can accept smaller changes while rejecting this PR (if you wish to do so).At the moment, the library ignores the
useTypoMetricsflag, which can lead to strange metrics in some cases. This branch solves this problem using the same algorithm as FreeType (https://gitlab.freedesktop.org/freetype/freetype/-/blob/4d8db130ea4342317581bab65fc96365ce806b77/src/sfnt/sfobjs.c#L1310).