No "X-Remote" header in Tab AJAX by default #3161
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is documented in the docs - https://github.com/fomantic/Fomantic-UI-Docs/blob/5ad17488bc/server/documents/modules/tab.html.eco#L644.
But I belive this concept is not unified across the whole Fomantic UI and forcing an extra HTTP header is not wanted in general.
It is always possible to detect the AJAX load like in https://github.com/atk4/ui/blob/5.2.0/src/App.php#L343 if header approach is wanted and it is guaranteed by the XMLHttpRequest spec.
If any special handling for "tab load" is wanted, "apiSettings.data" should be used instead like in https://github.com/atk4/ui/blob/5.2.0/src/TabsTab.php#L39. This has an advantage to work even thru proxies which can strip unknown headers easily.