Verify device id even if provided in config #457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
spotify_device_id
is provided in the config, you may still need to launch an app on Chromecast first to wake it up and make it available in the device list.Why
spotify_device_id
may be necessaryWhen Google Home devices are combined into a speaker pair, the Chromecast device name may be different from the Spotify device name. In that case, in
device_name
, you will want to use the friendly name of the Chromecast device. However, a device with that name won't be found in the list of Spotify devices, and you'll encounter an error. But if you addspotify_device_id
, the Chromecast won't need to be woken up.Other changes in this PR
I would also like to set up some basic CI to check formatting, run black, isort, codespell, and flake8. https://github.com/leikoilja/ha-google-home/ which I maintain can be a good example. Would you support such changes?