Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify device id even if provided in config #457

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

KapJI
Copy link

@KapJI KapJI commented Sep 7, 2024

If spotify_device_id is provided in the config, you may still need to launch an app on Chromecast first to wake it up and make it available in the device list.

Why spotify_device_id may be necessary

When Google Home devices are combined into a speaker pair, the Chromecast device name may be different from the Spotify device name. In that case, in device_name, you will want to use the friendly name of the Chromecast device. However, a device with that name won't be found in the list of Spotify devices, and you'll encounter an error. But if you add spotify_device_id, the Chromecast won't need to be woken up.

Other changes in this PR

  • Fixed several typing mistakes
  • Formatted the edited parts of the code according to Python guidelines
  • Removed duplicated code

I would also like to set up some basic CI to check formatting, run black, isort, codespell, and flake8. https://github.com/leikoilja/ha-google-home/ which I maintain can be a good example. Would you support such changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant