Skip to content

Commit

Permalink
On #8: More output to get to the cause of failing tests on github
Browse files Browse the repository at this point in the history
  • Loading branch information
lentschi committed Apr 28, 2024
1 parent 0773a13 commit 42fa59a
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 6 deletions.
14 changes: 11 additions & 3 deletions app/models/article.rb
Original file line number Diff line number Diff line change
Expand Up @@ -298,9 +298,17 @@ def reload_article_on_version_change
end

def version_dup_required?
return false if latest_article_version.nil?
return false unless latest_article_version.self_or_ratios_changed?
if latest_article_version.nil?
puts 'version_dup_required? no latest_article_version'

Check failure on line 302 in app/models/article.rb

View workflow job for this annotation

GitHub Actions / test

Rails/Output: Do not write to stdout. Use Rails's logger if you want to log.
return false
end
unless latest_article_version.self_or_ratios_changed?
puts 'version_dup_required? unchanged'

Check failure on line 306 in app/models/article.rb

View workflow job for this annotation

GitHub Actions / test

Rails/Output: Do not write to stdout. Use Rails's logger if you want to log.
return false
end

OrderArticle.belonging_to_finished_order.exists?(article_version_id: latest_article_version.id)
ret = OrderArticle.belonging_to_finished_order.exists?(article_version_id: latest_article_version.id)
puts "version_dup_required? finished_order? #{ret}"

Check failure on line 311 in app/models/article.rb

View workflow job for this annotation

GitHub Actions / test

Rails/Output: Do not write to stdout. Use Rails's logger if you want to log.

Check failure on line 311 in app/models/article.rb

View workflow job for this annotation

GitHub Actions / test

Layout/TrailingWhitespace: Trailing whitespace detected.
ret
end
end
16 changes: 13 additions & 3 deletions spec/models/article_version_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,23 @@

order.finish!(admin)

puts 'Updating...'
article.update(latest_article_version_attributes: new_attributes.merge(id: article_version.id))

new_version = article.latest_article_version
version_in_order = order.order_articles.first.reload.article_version

puts "ID: #{original_version_id} <-> #{version_in_order.id} vs #{new_version.id}"
new_version.attributes.except('id').each_key do |key|
puts "#{original_version[key] == version_in_order[key] ? 'EQ' : 'NEQ'}: '#{key}': {#{original_version[key]}} <-> {#{version_in_order[key]}}"
end

expect(original_version_id).not_to eq new_version.id
expect(original_version_id).to eq version_in_order.id
new_attributes.each do |key, value|
expect(article.latest_article_version[key]).to eq value
expect(order.order_articles.first.article_version[key]).to eq original_version[key]
expect(new_version[key]).to eq value
expect(version_in_order[key]).to eq(original_version[key]), "'#{key}' property changed: Old {#{original_version[key]}} <-> Current {#{version_in_order[key]}}"
end
expect(original_version_id).not_to eq article.latest_article_version.id
end
end

Expand Down

0 comments on commit 42fa59a

Please sign in to comment.