-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Actions #3769
Merged
Merged
GitHub Actions #3769
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8806f86
Add Github Actions
brandonpage c9ace33
Add dynamic testing matrix for PRs, static analysis and test summary …
brandonpage 623204d
Add test-orchestrator so unit tests start before static analysis is f…
brandonpage c8c74e3
Fix secrets inheritance.
brandonpage 1362002
no message
brandonpage f445324
no message
brandonpage 6d07289
Move to pull_request_target event with member check.
brandonpage a77d4ea
Remove check if CI files are modified.
brandonpage f7386a4
Use xcbeautify for test runs and adjust for new single xcode version …
brandonpage c599165
Add owner to author check to make it easier simpler to test CI from f…
brandonpage File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
source("https://rubygems.org") | ||
|
||
gem 'danger' | ||
gem 'plist' | ||
gem 'danger-xcode_summary' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
GEM | ||
remote: https://rubygems.org/ | ||
specs: | ||
addressable (2.8.7) | ||
public_suffix (>= 2.0.2, < 7.0) | ||
base64 (0.2.0) | ||
claide (1.1.0) | ||
claide-plugins (0.9.2) | ||
cork | ||
nap | ||
open4 (~> 1.3) | ||
colored2 (3.1.2) | ||
cork (0.3.0) | ||
colored2 (~> 3.1) | ||
danger (9.5.1) | ||
base64 (~> 0.2) | ||
claide (~> 1.0) | ||
claide-plugins (>= 0.9.2) | ||
colored2 (~> 3.1) | ||
cork (~> 0.1) | ||
faraday (>= 0.9.0, < 3.0) | ||
faraday-http-cache (~> 2.0) | ||
git (~> 1.13) | ||
kramdown (~> 2.3) | ||
kramdown-parser-gfm (~> 1.0) | ||
octokit (>= 4.0) | ||
pstore (~> 0.1) | ||
terminal-table (>= 1, < 4) | ||
danger-plugin-api (1.0.0) | ||
danger (> 2.0) | ||
danger-xcode_summary (1.3.1) | ||
danger-plugin-api (~> 1.0) | ||
xcresult (~> 0.2.2) | ||
faraday (2.12.0) | ||
faraday-net_http (>= 2.0, < 3.4) | ||
json | ||
logger | ||
faraday-http-cache (2.5.1) | ||
faraday (>= 0.8) | ||
faraday-net_http (3.3.0) | ||
net-http | ||
git (1.19.1) | ||
addressable (~> 2.8) | ||
rchardet (~> 1.8) | ||
json (2.7.5) | ||
kramdown (2.4.0) | ||
rexml | ||
kramdown-parser-gfm (1.1.0) | ||
kramdown (~> 2.0) | ||
logger (1.6.1) | ||
nap (1.1.0) | ||
net-http (0.4.1) | ||
uri | ||
octokit (9.2.0) | ||
faraday (>= 1, < 3) | ||
sawyer (~> 0.9) | ||
open4 (1.3.4) | ||
plist (3.7.1) | ||
pstore (0.1.3) | ||
public_suffix (6.0.1) | ||
rchardet (1.8.0) | ||
rexml (3.3.9) | ||
sawyer (0.9.2) | ||
addressable (>= 2.3.5) | ||
faraday (>= 0.17.3, < 3) | ||
terminal-table (3.0.2) | ||
unicode-display_width (>= 1.1.1, < 3) | ||
unicode-display_width (2.6.0) | ||
uri (0.13.1) | ||
xcresult (0.2.2) | ||
|
||
PLATFORMS | ||
arm64-darwin-23 | ||
ruby | ||
|
||
DEPENDENCIES | ||
danger | ||
danger-xcode_summary | ||
plist | ||
|
||
BUNDLED WITH | ||
2.5.22 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
require 'plist' | ||
|
||
# Markdown table character length without any issues | ||
MAKRDOWN_LENGTH = 138 | ||
LIBS = ['SalesforceSDKCommon', 'SalesforceAnalytics', 'SalesforceSDKCore', 'SmartStore', 'MobileSync'] | ||
|
||
files = Set[] | ||
for lib in LIBS; | ||
files.merge(Dir["../../libs/#{lib}/clangReport/StaticAnalyzer/#{lib}/#{lib}/normal/**/*.plist"]) | ||
end | ||
print "Found #{files.count} classes with static analysis files.\n" | ||
|
||
modified_file_names = git.modified_files.map { |file| File.basename(file, File.extname(file)) } | ||
added_file_names = git.added_files.map { |file| File.basename(file, File.extname(file)) } | ||
|
||
# Github PR comment header | ||
message = "### Clang Static Analysis Issues\n\n" | ||
message << "File | Type | Category | Description | Line | Col |\n" | ||
message << " --- | ---- | -------- | ----------- | ---- | --- |\n" | ||
|
||
# Parse Clang Plist files and report issues associated with files modified or added in this PR. | ||
for file in files; | ||
report = Plist.parse_xml(file) | ||
report_file_name = File.basename(file, File.extname(file)) | ||
print "File with clang report: #{report_file_name}\n" | ||
|
||
if modified_file_names.include?(report_file_name) || added_file_names.include?(report_file_name) | ||
issues = report['diagnostics'] | ||
print "File modified in PR: #{file}, has #{issue.count} issues.\n" | ||
for i in 0..issues.count-1 | ||
unless issues[i].nil? | ||
message << "#{report_file_name} | #{issues[i]['type']} | #{issues[i]['category']} | #{issues[i]['description']} | #{issues[i]['location']['line']} | #{issues[i]['location']['col']}\n" | ||
end | ||
end | ||
end | ||
end | ||
|
||
# Only print Static Analysis table if there are issues | ||
if message.length > MAKRDOWN_LENGTH | ||
warn('Static Analysis found an issue with one or more files you modified. Please fix the issue(s).') | ||
markdown message | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# List of supported xcode schemes for testing | ||
SCHEMES = ['SalesforceSDKCommon', 'SalesforceAnalytics', 'SalesforceSDKCore', 'SmartStore', 'MobileSync'] | ||
|
||
modifed_libs = Set[] | ||
for file in (git.modified_files + git.added_files); | ||
scheme = file.split("libs/").last.split("/").first | ||
print "lib: #{scheme}\n" | ||
if scheme == '.github' | ||
# If CI files are modified, run all tests | ||
modifed_libs.merge(SCHEMES) | ||
elsif SCHEMES.include?(scheme) | ||
modifed_libs.add(scheme) | ||
end | ||
end | ||
|
||
# Set Github Job output so we know which tests to run | ||
json_libs = modifed_libs.map { |l| "'#{l}'"}.join(", ") | ||
`echo "libs=[#{json_libs}]" >> $GITHUB_OUTPUT` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
xcode_summary.ignores_warnings = true | ||
xcode_summary.inline_mode = true | ||
xcode_summary.report '../../test.xcresult' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
name: Nightly Tests | ||
|
||
on: | ||
schedule: | ||
- cron: "0 5 * * 3,5" # cron is UTC, this translates to 10 PM PST Tues and Thur. | ||
|
||
jobs: | ||
ios-pr: | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
lib: [SalesforceSDKCommon, SalesforceAnalytics, SalesforceSDKCore, SmartStore, MobileSync] | ||
ios: [^18, ^17] | ||
uses: ./.github/workflows/reusable-workflow.yaml | ||
with: | ||
lib: ${{ matrix.lib }} | ||
ios: ${{ matrix.ios }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
name: Pull Request | ||
|
||
on: | ||
pull_request: | ||
branches: | ||
- dev | ||
|
||
jobs: | ||
static-analysis: | ||
runs-on: macos-latest | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v4 | ||
with: | ||
fetch-depth: 100 | ||
- name: Install Dependencies | ||
run: | | ||
npm install [email protected] | ||
./install.sh | ||
- name: Run Static Analysis | ||
# It would be nice to use xcbeaufity here but all the warnings and errors get annotated onto the PR, including | ||
# files not mofified in the PR which is annoying. | ||
run: xcodebuild analyze -workspace SalesforceMobileSDK.xcworkspace -scheme MobileSync -sdk 'iphonesimulator' \ | ||
CLANG_ANALYZER_OUTPUT=plist-html CLANG_ANALYZER_OUTPUT_DIR=./clangReport RUN_CLANG_STATIC_ANALYZER=YES | ||
- name: Report Static Analysis | ||
env: | ||
DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
run: | | ||
cd .github/DangerFiles | ||
bundle update && bundle install | ||
bundle exec danger --dangerfile=StaticAnalysis.rb --danger_id=StaticAnalysis | ||
|
||
test-orchestrator: | ||
runs-on: macos-latest | ||
outputs: | ||
libs: ${{ steps.test-orchestrator.outputs.libs }} | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v4 | ||
with: | ||
fetch-depth: 100 | ||
- name: Determine Tests to Run | ||
id: test-orchestrator | ||
env: | ||
DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
run: | | ||
cd .github/DangerFiles | ||
bundle update && bundle install | ||
bundle exec danger --dangerfile=TestOrchestrator.rb | ||
|
||
ios-pr: | ||
needs: [test-orchestrator] | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
lib: ${{ fromJson(needs.test-orchestrator.outputs.libs) }} | ||
uses: ./.github/workflows/reusable-workflow.yaml | ||
with: | ||
lib: ${{ matrix.lib }} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to leave the various prints in this file so we can check it is working. It's not super obvious if it breaks because it only reports issues in files modified in the PR.