Merge pull request #1429 from ashitsalesforce/master

make the process tests fail if used memory at end of the test goes up…
forcedotcom · Dec 31, 2024 · 8690303 · 8690303
2 parents 811dfaa + ae85744
commit 8690303
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/java_pid11058.hprof b/java_pid11058.hprof
diff --git a/src/test/java/com/salesforce/dataloader/process/ProcessTestBase.java b/src/test/java/com/salesforce/dataloader/process/ProcessTestBase.java
@@ -90,12 +90,11 @@ public void setUpMemoryProfiling() throws Exception {
     public void tearDownMemoryProfiling() throws Exception {
         System.gc();
         long usedMemoryAfter = runtime.totalMemory() - runtime.freeMemory();
-        long memoryIncreaseAfterUse = usedMemoryAfter - usedMemoryBefore;
-        if (memoryIncreaseAfterUse > 2000000) {
-            System.out.println("\n==========================");
-            System.out.println("memory increase after use: " + memoryIncreaseAfterUse / 1024/1024 + "Mb");
-            System.out.println("==========================\n");
+        long memoryIncreaseAfterUseInMb = (usedMemoryAfter - usedMemoryBefore)/1024/1024;
+        if (memoryIncreaseAfterUseInMb > 2) {
+            logger.warn("memory increase after use: " + memoryIncreaseAfterUseInMb + "Mb");
         }
+        assertTrue("potential memory leak", memoryIncreaseAfterUseInMb < 20);
         AppUtil.enableUsedHeapCapture(false);
     }