Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@W-14742535@ Fix: definition-file keys case sensitivity #535

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

mradulsf
Copy link
Collaborator

@mradulsf mradulsf commented Mar 28, 2024

The creation of the scratch org (build org) during the “package version create” command results in the org created without snapshot, because the snapshot property is null, even though the snapshot is specified in the scratch org definition file as "snapShot".

While the scratch org is successfully created using the ‘snapShot’ property (uppercase ‘S’) with the “scratch org create” command. We should match this behavior.

  • Actual Result

Scratch org (build org) created without the properties of Snapshot. For ex: Profiles that are created on the snapshotted org are missing in the build org.

  • Expected Result

Scratch org (build org) should be created with the properties of Snapshot. The "package version create" command should not fail due to a missing custom profile that was from the snapshotted org.

@W-14742535@

Copy link

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Mradul Agrawal <m***@m***.i***.s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated.

@mradulsf mradulsf marked this pull request as ready for review March 29, 2024 19:52
@mradulsf
Copy link
Collaborator Author

mradulsf commented Apr 1, 2024

retest

@shetzel shetzel merged commit 5ff6f96 into main Apr 1, 2024
10 of 12 checks passed
@shetzel shetzel deleted the magrawal/W-14742535 branch April 1, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants