Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move verbose field to default fields #548

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Conversation

mradulsf
Copy link
Collaborator

Move the non-CodeCoverage fields from the verbose query to the default query so that JSON responses are more accurate.

@W-15398724@

Copy link

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Mradul Agrawal <m***@m***.i***.s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated.

@mradulsf mradulsf requested review from shetzel and SagarBijjam April 16, 2024 17:30
Copy link
Collaborator

@SagarBijjam SagarBijjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mradulsf the WI mentioned about similarly affected packaging commands. have you come across any. Like package:version:create:report command that have similar fields

@mradulsf
Copy link
Collaborator Author

@SagarBijjam Yes, I made change to another file for package version report. Is that not the one you are talking about?

Copy link
Contributor

@shetzel shetzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update packageTest.nut.ts line 279 to now expect the Id as a property of the returned result since you added it to the query.
In other words, it should now be:
expect(result).to.have.property('Id');

Our preference is to test public APIs rather than exposing a private function and unit testing that.

@SagarBijjam
Copy link
Collaborator

@SagarBijjam Yes, I made change to another file for package version report. Is that not the one you are talking about?

I was referring to package:version:create:report, but it seems that the command doesn't have similar verbose fields. So skip it

@shetzel shetzel closed this Apr 18, 2024
@shetzel shetzel reopened this Apr 18, 2024
@shetzel shetzel merged commit 3d8d443 into main Apr 18, 2024
11 of 12 checks passed
@shetzel shetzel deleted the ma/less-verbose-fields branch April 18, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants