-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move verbose field to default fields #548
Conversation
Thanks for the contribution! Unfortunately we can't verify the commit author(s): Mradul Agrawal <m***@m***.i***.s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mradulsf the WI mentioned about similarly affected packaging commands. have you come across any. Like package:version:create:report
command that have similar fields
@SagarBijjam Yes, I made change to another file for package version report. Is that not the one you are talking about? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to update packageTest.nut.ts
line 279 to now expect the Id
as a property of the returned result since you added it to the query.
In other words, it should now be:
expect(result).to.have.property('Id');
Our preference is to test public APIs rather than exposing a private function and unit testing that.
I was referring to |
Move the non-CodeCoverage fields from the verbose query to the default query so that JSON responses are more accurate.
@W-15398724@