test: add xNUTs to GHA #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillieRuemmele
approved these changes
Apr 22, 2024
| command: 'yarn test:nuts:package' | ||
| os: ${{ matrix.os }} | ||
| preSwapCommands: 'yarn upgrade @salesforce/core; npx yarn-deduplicate; yarn install' | ||
| preExternalBuildCommands: 'npm why @salesforce/core --json' |
There was a problem hiding this comment.
do we need this, or was it for debugging?
There was a problem hiding this comment.
Arguably both. I added it for debugging but it won't harm anything to keep it. That way when tsc fails when building the xNUT repo we can see why, at least for @salesforce/core. I can remove it though.
QA Notes
✅ : the ext NUTs built/ran/passed on my test PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the plugin-packaging NUTs to the test workflow for GHA so we can know if changes to this library will break the plugin.
@W-15534460@