Skip to content

Commit

Permalink
chore: report error whenever there is one
Browse files Browse the repository at this point in the history
  • Loading branch information
mingxuanzhangsfdx committed Oct 3, 2024
1 parent 0575b4a commit 8bbfce4
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions scripts/bundleWithCheck.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ const commandToRun = 'yarn build && node ./scripts/build.js';
exec(commandToRun, (error, stdout, stderr) => {
// Combine stdout and stderr to check the entire output
const output = `${stdout}\n${stderr}`;
if (error) {
console.error(output);
process.exit(1); // Exit with an error code
}
// Check if the output contains the error string of esbuild
if (output.includes('[require-resolve-not-external]')) {
console.error('Error: A dependency that has to be externalized in esbuild process is found. Please resolve it!');
Expand Down

3 comments on commit 8bbfce4

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: 8bbfce4 Previous: 0e5ffe8 Ratio
Child logger creation 484484 ops/sec (±1.27%) 477952 ops/sec (±0.84%) 0.99
Logging a string on root logger 930429 ops/sec (±11.18%) 906460 ops/sec (±9.76%) 0.97
Logging an object on root logger 36801 ops/sec (±186.50%) 42060 ops/sec (±184.50%) 1.14
Logging an object with a message on root logger 472586 ops/sec (±6.76%) 450775 ops/sec (±6.82%) 0.95
Logging an object with a redacted prop on root logger 578849 ops/sec (±6.48%) 551557 ops/sec (±6.10%) 0.95
Logging a nested 3-level object on root logger 13929 ops/sec (±200.50%) 17376 ops/sec (±195.40%) 1.25

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: 8bbfce4 Previous: 0e5ffe8 Ratio
Child logger creation 335692 ops/sec (±1.46%) 339861 ops/sec (±1.03%) 1.01
Logging a string on root logger 825748 ops/sec (±9.00%) 901919 ops/sec (±5.75%) 1.09
Logging an object on root logger 628532 ops/sec (±3.83%) 630759 ops/sec (±8.76%) 1.00
Logging an object with a message on root logger 4266 ops/sec (±213.14%) 12581 ops/sec (±189.16%) 2.95
Logging an object with a redacted prop on root logger 429000 ops/sec (±19.07%) 474492 ops/sec (±6.51%) 1.11
Logging a nested 3-level object on root logger 315024 ops/sec (±6.16%) 316533 ops/sec (±5.57%) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - windows-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 8bbfce4 Previous: 0e5ffe8 Ratio
Logging an object with a message on root logger 4266 ops/sec (±213.14%) 12581 ops/sec (±189.16%) 2.95

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.