feat(generateScratchOrgInfo): allow shema key

[alanjaouen]

What does this PR do?

This pr remove $schema key from parsed scratchorg definition. allowing to pass check scratchOrgInfoPayload must be heads down camelcase. and so preventing InvalidJsonCasing exceptions

What issues does this PR fix or reference?

InvalidJsonCasing are raised if definition file contains $schema key (from documentation)

[mshanemc]

Cool, thanks for noticing and fixing.

Are you willing/able to add a unit test for that? It should probably go in this describe block

sfdx-core/test/unit/org/scratchOrgInfoGenerator.test.ts

Lines 600 to 601 in e8b0980

	describe('generateScratchOrgInfo', () => {
	const testData = new MockTestOrgData();

(pass it an object with your $schema property and verify that it's removed.

Your code looks fine and I'm sure it works, but the test will preserve the behavior through future refactorings.

[git2gus]

This issue has been linked to a new work item: W-16441182

[alanjaouen]

Thanks for feedback

I added a test for this, let me know if there is a better way to make this test

[mshanemc]

Looks great, thanks for doing that.

I reorganized the tests a bit and moved it to a branch on our repo so all the integration tests can run.
#1124