Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W-16618249 fix: resolve fullname correctly for EmailTemplateFolder #679

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

shetzel
Copy link
Collaborator

@shetzel shetzel commented Sep 25, 2024

What does this PR do?

Some SourceMember types are mapped to different metadata types in SDR. EmailTemplateFolder is one of them; it maps to EmailFolder which is treated as an alias in SDR. The FullName parsing was updated to use the entire FullName rather than following a substring pattern for other mapped types like Aura and LWC.

What issues does this PR fix or reference?

@W-16618249@
forcedotcom/cli#2902

@shetzel shetzel requested a review from a team as a code owner September 25, 2024 16:56
@WillieRuemmele
Copy link
Member

QA Notes


create an org with multiple layers of email templates / email template folders

✅ : retrieve preview shows multiple EmailFolders not just the toplevel
✅ : retrieve start retrieves everything correctly
✅ : deploy preview correctly tracks changes, and local changes

@WillieRuemmele WillieRuemmele merged commit c472e70 into main Sep 25, 2024
34 checks passed
@WillieRuemmele WillieRuemmele deleted the sh/source-tracked-email-templates branch September 25, 2024 19:23
@iowillhoit iowillhoit changed the title fix: resolve fullname correctly for EmailTemplateFolder W-16618249 fix: resolve fullname correctly for EmailTemplateFolder Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants