Add features options when searching or verifying MSRV
#834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foresterre
changed the title
features flag when running check with cargo features options when running check with cargo
foresterre
changed the title
features options when running check with cargo features options when searching or verifying MSRV
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #834 +/- ##
==========================================
+ Coverage 75.22% 75.57% +0.35%
==========================================
Files 81 82 +1
Lines 6118 6255 +137
==========================================
+ Hits 4602 4727 +125
- Misses 1516 1528 +12 ☔ View full report in Codecov by Sentry. |
foresterre
force-pushed
the
feat/gh-832
branch
3 times, most recently
from
6405fc1 to
066aed6
Compare
foresterre
force-pushed
the
feat/gh-832
branch
2 times, most recently
from
9d6c8ea to
f59ce84
Compare
* Adds CargoCommand struct * Unlike RustupCommand, not (yet) intended to run standalone, since we use rustup to run certain versions of toolchains * Currently only used for "cargo check", but could be refactored to also include the likes of "cargo build" and friends (cargo build support could help for adding support for Rust < 1.16). * Has options to forward features and target to cargo
foresterre
force-pushed
the
feat/gh-832
branch
from
f59ce84 to
f7b23c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #832