fix has_avatar default in object_resource

forevanyeung · Nov 6, 2023 · db2a3b9 · db2a3b9
1 parent 55740b3
commit db2a3b9
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/internal/provider/object_resource.go b/internal/provider/object_resource.go
@@ -10,6 +10,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-framework/path"
 	"github.com/hashicorp/terraform-plugin-framework/resource"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema"
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/booldefault"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/stringplanmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/types"
@@ -137,6 +138,8 @@ func (r *objectResource) Schema(_ context.Context, _ resource.SchemaRequest, res
 			},
 			"has_avatar": schema.BoolAttribute{
 				Optional: true,
+				Computed: true,
+				Default:  booldefault.StaticBool(false),
 			},
 			"avatar_uuid": schema.StringAttribute{
 				Optional:    true,

diff --git a/internal/provider/object_resource_test.go b/internal/provider/object_resource_test.go
@@ -28,6 +28,25 @@ func TestAccJiraAssetsObjectResource(t *testing.T) {
 					resource.TestCheckResourceAttr("jiraassets_object.test", "attributes.#", "2"),
 				),
 			},
+			{
+				Config: `resource "jiraassets_object" "test_avatar" {
+					type_id = "117"
+					attributes = [
+						{
+							attr_type_id = "1087"
+							attr_value = "My Phone"
+						},
+						{
+							attr_type_id = "1090"
+							attr_value = "1234657890"
+						}
+					]
+					has_avatar = true
+				}`,
+				Check: resource.ComposeAggregateTestCheckFunc(
+					resource.TestCheckResourceAttr("jiraassets_object.test_avatar", "attributes.#", "2"),
+				),
+			},
 		},
 	})
 }