Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced Link component to handle language switching and persistance properly #36

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AlemTuzlak
Copy link
Contributor

Description

The Link and LanguageSwitcher components didn't fully handle the redirects with the ?lng=X param in the search param, this PR aims to address this issue and enhance the components

Type of change

Please mark relevant options with an x in the brackets.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Algorithm update - updates algorithm documentation/questions/answers etc.
  • Other (please describe):

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration

  • Integration tests
  • Unit tests
  • Manual tests
  • No tests required

Reviewer checklist

Mark everything that needs to be checked before merging the PR.

  • Check if the UI is working as expected and is satisfactory
  • Check if the code is well documented
  • Check if the behavior is what is expected
  • Check if the code is well tested
  • Check if the code is readable and well formatted
  • Additional checks (document below if any)

Screenshots (if appropriate):

Questions (if appropriate):

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 86.79% 138 / 159
🔵 Statements 86.79% 138 / 159
🔵 Functions 63.63% 7 / 11
🔵 Branches 94.73% 18 / 19
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
app/library/link/link.tsx 100% 100% 100% 100%
app/library/link/useEnhancedTo.ts 100% 100% 100% 100%
Generated in workflow #147 for commit 6074195 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant