Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed unnecessary console logs #159

Merged
merged 3 commits into from
Oct 31, 2024
Merged

removed unnecessary console logs #159

merged 3 commits into from
Oct 31, 2024

Conversation

abrulic1
Copy link
Contributor

Description

Removed unnecessary console log
Added biome rule for console log

Fixes #158

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings or errors
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 31, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 86.44% (🎯 80%) 708 / 819
🟢 Statements 86.44% (🎯 80%) 708 / 819
🟢 Functions 71.87% (🎯 70%) 23 / 32
🟢 Branches 83.33% (🎯 75%) 75 / 90
File CoverageNo changed files found.
Generated in workflow #42 for commit 53b962d by the Vitest Coverage Report Action

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 31, 2024 •
edited
Loading

Open in Stackblitz

yarn add https://pkg.pr.new/forge42dev/Remix-Dev-Tools/[email protected]

commit: 53b962d

@abrulic1 abrulic1 marked this pull request as draft October 31, 2024 09:04
@abrulic1 abrulic1 marked this pull request as ready for review October 31, 2024 09:10
@abrulic1 abrulic1 requested a review from AlemTuzlak October 31, 2024 09:11
AlemTuzlak
AlemTuzlak reviewed Oct 31, 2024
View reviewed changes
package.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you didn't bump the minor

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@AlemTuzlak AlemTuzlak merged commit a9cfeec into main Oct 31, 2024
6 checks passed
@AlemTuzlak AlemTuzlak deleted the 158-pollution-of-browser-console-logs branch October 31, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlemTuzlak AlemTuzlak AlemTuzlak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pollution of browser console logs
2 participants
@abrulic1 @AlemTuzlak