Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ci: added referer to GOE post in release workflow #376

Merged
merged 4 commits into from
May 17, 2024

Conversation

juarezr
Copy link
Contributor

@juarezr juarezr commented Apr 7, 2024

fix: ci: added referer to GOE post in release workflow

@juarezr
Copy link
Contributor Author

juarezr commented Apr 7, 2024

Work in progress...

@jmmaranan
Copy link
Collaborator

I am curious if the upload really works. I am ready to pass the EGO account if this works.

@juarezr
Copy link
Contributor Author

juarezr commented Apr 11, 2024

I am curious if the upload really works. I am ready to pass the EGO account if this works.

@jmmaranan

  • The code in the last commit worked on my computer.
  • Maybe something remains and that could manifest while running the workflow, but we are going to know just trying.
  • But before running, you must create 2 secrets in this git repository:
    • GOE_USERNAME
    • GOE_PASSWORD

@juarezr juarezr requested a review from jmmaranan April 11, 2024 03:01
@jmmaranan jmmaranan requested review from p1gp1g and removed request for jmmaranan April 12, 2024 13:21
@jmmaranan
Copy link
Collaborator

* But before running, you must create 2 secrets in this git repository:
  
  * GOE_USERNAME
  * GOE_PASSWORD

I have added the secrets.

@juarezr
Copy link
Contributor Author

juarezr commented Apr 14, 2024

* But before running, you must create 2 secrets in this git repository:
  
  * GOE_USERNAME
  * GOE_PASSWORD

I have added the secrets.

  • PR's or commits will not trigger the release workflow.
  • But it is possible to test it by triggering:
  • If you'd prefer to take a little extra caution, you can put a fake password and check if the password leaks in the logs of the action page. Locally I haven't found any leakage.

@jmmaranan jmmaranan merged commit 56253c7 into forge-ext:main May 17, 2024
6 checks passed
@jmmaranan
Copy link
Collaborator

@juarezr - I have to disable the release to GOE for now. I might bring it back before the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants