polishing: No double negations #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 21, 2018 17:02
This avoids confusing situations where we are doing "ifNdef NO_...". Debugging is hard enough as it is, without having to do double logic inversions on the side :-) This reasoning was inspired by the Rust-lang discussion about the "#[no_std]" feature.
Reduce the amount of conditional code, by extract the part that is identical in both cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Forkineye,
I'm very grateful to your excellent E131 code; I'm reading it to learn how to handle my own E131 on a particle photon.
In doing so, I kept struggling with the double negations around
#ifndef NO_DOUBLE_BUFFER.I've decided to flip it around for less confusion, and wanted to offer it up to you as "upstream", in case you might find it useful.
If you find it useful, please feel free to take it, I put this contribution into the public domain, so that you may use it in whatever way you see fit.
Thank you for the excellent library, I am going to fiddle with it further :-)