Skip to content

test(check.rb): add #extra_args instruction #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tueda
Copy link
Collaborator

@tueda tueda commented May 20, 2024

This is probably the simplest approach to resolve the issue (testing tform -w2) discussed in (#520 (comment)).

This patch adds a new special instruction #extra_args that can be used to add extra command-line arguments to be passed to FORM. For example

#extra_args -w2

leads to run tform -w4 -w2 1.frm for testing TFORM.

Instead of adding #extra_args, other options would be:

  1. Run all TFORM tests with -w2 and then with -w4.
  2. Add
    #threads 2,4
    
    to run TFORM tests with -w2 and then with -w4.

By using this instruction, one can add extra command-line arguments to
be passed to FORM. Example:
  #extra_args -w2
@jodavies
Copy link
Collaborator

I would say it is probably best to run the entire set of tests with both w2 and w4. I am not sure on the limits of github's runners. The valgrind tests are taking the majority of the time at the moment (and those should probably be run with both w2 and w4 as well, since different code runs...). #520 manifests even for very trivial input. Maybe there is even something in the current set of tests that doesn't work with w2...

@coveralls
Copy link

Coverage Status

coverage: 48.768% (+0.004%) from 48.764%
when pulling c34be2d on tueda:test-extra_args
into 87b4bcf on vermaseren:master.

@tueda
Copy link
Collaborator Author

tueda commented May 20, 2024

You are right. Adding -w2 actually caused many test failures... (I'll create a PR).

@tueda
Copy link
Collaborator Author

tueda commented May 30, 2025

This patch is not needed for now, but we may revisit it later.

@tueda tueda marked this pull request as draft May 30, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants