Skip to content

fix: memory leak in InsideDollar #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

fix: memory leak in InsideDollar #652

merged 1 commit into from
Jun 17, 2025

Conversation

jodavies
Copy link
Collaborator

Fixes the leak discovered in #648

@coveralls
Copy link

coveralls commented Jun 14, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 15676169172

Details

  • 7 of 8 (87.5%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 50.401%
Changes Missing Coverage Covered Lines Changed/Added Lines %
sources/dollar.c 7 8 87.5%
Files with Coverage Reduction New Missed Lines %
sources/threads.c 2 77.56%
Totals Coverage Status
Change from base Build 15649636236: 0.02%
Covered Lines: 41811
Relevant Lines: 82956
💛 - Coveralls

@jodavies
fix: memory leak in InsideDollar
c2c969d 
Working inside dollar variables leaked memory, specifically when the dollar variable is 0.
@jodavies
Copy link
Collaborator Author

Updated: I added a test, this leak is specifically when you work inside a dollar variable that is zero.

@jodavies jodavies added this to the v4.3.2 milestone Jun 16, 2025
@jodavies jodavies merged commit 6abc477 into form-dev:master Jun 17, 2025
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.3.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jodavies @coveralls