-
Notifications
You must be signed in to change notification settings - Fork 144
#StartFloat syntax #680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
#StartFloat syntax #680
Conversation
This looks like a good change, but remember to also update the manual. I would perhaps also merge the commits, since the CI will not pass on the first commit alone, and perhaps makes bisection a bit less smooth.
I think this is also a good idea, but maybe is better as part of #676 which is already changing how the allocation and precision is handled. |
…), MZV = <weight>. The precision can either be in bits (b) or digits (d). test: updated the evaluate_symbol tests for the new #StartFloat syntax. doc: updated manual with new #StartFloat syntax.
I updated the manual and merged the commits. Do we also want to add the new preprocessor commands and statements that come with the floating point system added earlier in the respective chapters? |
Yes I think so, at least in the style of "see the Floating point chapter", similar to optimize: https://www.nikhef.nl/~form/maindir/documentation/reference/html/manual.html#x1-550003.38 |
Allright, I will update the manual. At the moment the manual says that the first precision argument of |
Furthermore, with the new syntax, one could also relax the order of the two arguments in |
…#endfloat and also for the statements evaluate, tofloat and torational.
This PR updates the
#StartFloat
syntax as discussed in #676. The new syntax iswhere the precision can either be in bits (
b
) or digits (d
). For example:Notes:
SetFloatPrecision
fromSetupMZVTables
andSetupMPFTables
are both needed (both increase the precision by the MZV weight). Likely, a single call in e.g.DoStartFloat
should be sufficient.