-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update cobra #1
Commits on Nov 15, 2022
-
Create unit test illustrating unknown flag bug (spf13#1854)
Created a unit test that tests the unknown flag error message when the unknown flag is located in different arg positions.
Configuration menu - View commit details
-
Copy full SHA for ad6db7f - Browse repository at this point
Copy the full SHA ad6db7fView commit details
Commits on Nov 22, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4305498 - Browse repository at this point
Copy the full SHA 4305498View commit details
Commits on Nov 25, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c6b9971 - Browse repository at this point
Copy the full SHA c6b9971View commit details -
Makefile: add target richtest (spf13#1865)
Don't require contributors to install richgo but keep it as an option and for CI
Configuration menu - View commit details
-
Copy full SHA for 6200c8e - Browse repository at this point
Copy the full SHA 6200c8eView commit details
Commits on Nov 26, 2022
-
build(deps): bump golangci/golangci-lint-action from 3.2.0 to 3.3.1 (s…
…pf13#1851) Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.2.0 to 3.3.1. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v3.2.0...v3.3.1) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 7bb1440 - Browse repository at this point
Copy the full SHA 7bb1440View commit details
Commits on Dec 6, 2022
-
Update kubescape org (spf13#1874)
Signed-off-by: David Wertenteil <[email protected]>
David Wertenteil committedDec 6, 2022 Configuration menu - View commit details
-
Copy full SHA for a6f198b - Browse repository at this point
Copy the full SHA a6f198bView commit details
Commits on Dec 9, 2022
-
ci: deprecate go 1.15 (spf13#1866)
Remove testing for go 1.15 to allow CI to pass, but don't force projects to upgrade.
Configuration menu - View commit details
-
Copy full SHA for 9235920 - Browse repository at this point
Copy the full SHA 9235920View commit details
Commits on Dec 15, 2022
-
fix: conflict import name with variable (spf13#1879)
`template` is an import in `cobra.go` file and also used as a variable name, which masks the library in the scope of that function.
Configuration menu - View commit details
-
Copy full SHA for f25a3c6 - Browse repository at this point
Copy the full SHA f25a3c6View commit details
Commits on Dec 23, 2022
-
Configuration menu - View commit details
-
Copy full SHA for fdffa5a - Browse repository at this point
Copy the full SHA fdffa5aView commit details
Commits on Dec 25, 2022
-
fix: func name in doc strings (spf13#1885)
Corrected the function name at the start of doc strings, as per the convention outlined in official go documentation: https://go.dev/blog/godoc
Configuration menu - View commit details
-
Copy full SHA for bf11ab6 - Browse repository at this point
Copy the full SHA bf11ab6View commit details
Commits on Jan 3, 2023
-
completions: do not detect arguments with dash as 2nd char as flag (s…
…pf13#1817) Fixes spf13#1816 Previously, arguments with a dash as the second character (e.g., 1-ff00:0:1) were detected as a flag by mistake. This resulted in auto completion misbehaving if such an argument was last in the argument list during invocation.
Configuration menu - View commit details
-
Copy full SHA for b4f979a - Browse repository at this point
Copy the full SHA b4f979aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fa4fdf - Browse repository at this point
Copy the full SHA 4fa4fdfView commit details
Commits on Jan 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d022c0f - Browse repository at this point
Copy the full SHA d022c0fView commit details
Commits on Feb 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8b8ee87 - Browse repository at this point
Copy the full SHA 8b8ee87View commit details
Commits on Feb 9, 2023
-
Update shell_completions.md (spf13#1907)
align documentation with the code : completions.go:452
Configuration menu - View commit details
-
Copy full SHA for 87ebcd8 - Browse repository at this point
Copy the full SHA 87ebcd8View commit details
Commits on Feb 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e839bb3 - Browse repository at this point
Copy the full SHA e839bb3View commit details
Commits on Feb 14, 2023
-
Removes stale bot from GitHub action (spf13#1908)
Signed-off-by: John McBride <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a516d41 - Browse repository at this point
Copy the full SHA a516d41View commit details
Commits on Feb 25, 2023
-
Add keeporder to shell completion (spf13#1903)
This allows programs to request the shell to maintain the order of completions that was returned by the program
Configuration menu - View commit details
-
Copy full SHA for 3daa4b9 - Browse repository at this point
Copy the full SHA 3daa4b9View commit details -
Add support for PowerShell 7.2+ (spf13#1916)
PowerShell 7.2 has changed the way arguments are passed to executables. This was originally an experimental feature in 7.2, but as of 7.3 it is built-in. A simple "" is now sufficient for passing empty arguments, no back-tick escaping is required. Fixes spf13#1849 Signed-off-by: Oldřich Jedlička <[email protected]> Co-authored-by: Oldřich Jedlička <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 567ea8e - Browse repository at this point
Copy the full SHA 567ea8eView commit details
Commits on Mar 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c7300f0 - Browse repository at this point
Copy the full SHA c7300f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb36524 - Browse repository at this point
Copy the full SHA fb36524View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e6b58a - Browse repository at this point
Copy the full SHA 9e6b58aView commit details
Commits on Mar 14, 2023
-
Update projects_using_cobra.md (spf13#1932)
Signed-off-by: Florent Poinsard <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b197a24 - Browse repository at this point
Copy the full SHA b197a24View commit details
Commits on Mar 17, 2023
-
Document suggested layout for subcommands (spf13#1930)
Signed-off-by: Luiz Carvalho <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c8a20a1 - Browse repository at this point
Copy the full SHA c8a20a1View commit details
Commits on Mar 22, 2023
-
Allow sourcing zsh completion script (spf13#1917)
Although it is not the recommended approach, sourcing a completion script is the simplest way to get people to try using shell completion. Not allowing it for zsh has turned out to complicate shell completion adoption. Further, many tools modify the zsh script to allow sourcing. This commit allows sourcing of the zsh completion script. Signed-off-by: Marc Khouzam <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 45360a5 - Browse repository at this point
Copy the full SHA 45360a5View commit details -
Update main image to better handle dark background (spf13#1883)
Fixes spf13#1880 Signed-off-by: Marc Khouzam <[email protected]> Co-authored-by: Deleplace <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4dd4b25 - Browse repository at this point
Copy the full SHA 4dd4b25View commit details
Commits on Apr 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 284f410 - Browse repository at this point
Copy the full SHA 284f410View commit details
Commits on Jun 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0e3a0bf - Browse repository at this point
Copy the full SHA 0e3a0bfView commit details
Commits on Jun 13, 2023
-
Fix grammar: 'allows to' (spf13#1978)
The use in generated bash completion files is getting flagged by Lintian (the Debian package linting tool). Signed-off-by: Taavi Väänänen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2246fa8 - Browse repository at this point
Copy the full SHA 2246fa8View commit details
Commits on Jun 16, 2023
-
test: make fish_completions_test more robust (spf13#1980)
Use temporary files instead of assuming the current directory is writable. Also, if creating a temporary file still returns an error, prevent the test from failing silently by replacing `log.Fatal` with `t.Fatal`.
Configuration menu - View commit details
-
Copy full SHA for 988bd76 - Browse repository at this point
Copy the full SHA 988bd76View commit details
Commits on Jun 19, 2023
-
powershell: escape variable with curly brackets (spf13#1960)
This fixes an issue with program names that include a dot, in our case `podman.exe`. This was caused by the change in commit 6ba7ebb. Fixes spf13#1853 Signed-off-by: Paul Holzinger <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fdee73b - Browse repository at this point
Copy the full SHA fdee73bView commit details
Commits on Jun 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for cbe4865 - Browse repository at this point
Copy the full SHA cbe4865View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcb405a - Browse repository at this point
Copy the full SHA dcb405aView commit details
Commits on Jul 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c81c46a - Browse repository at this point
Copy the full SHA c81c46aView commit details
Commits on Jul 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 66b215b - Browse repository at this point
Copy the full SHA 66b215bView commit details
Commits on Jul 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 60d056d - Browse repository at this point
Copy the full SHA 60d056dView commit details
Commits on Jul 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fd865a4 - Browse repository at this point
Copy the full SHA fd865a4View commit details
Commits on Aug 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4955da7 - Browse repository at this point
Copy the full SHA 4955da7View commit details
Commits on Aug 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 285460d - Browse repository at this point
Copy the full SHA 285460dView commit details
Commits on Sep 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c5dacb3 - Browse repository at this point
Copy the full SHA c5dacb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c72800 - Browse repository at this point
Copy the full SHA 0c72800View commit details
Commits on Sep 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for bd4d165 - Browse repository at this point
Copy the full SHA bd4d165View commit details
Commits on Oct 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 95d8a1e - Browse repository at this point
Copy the full SHA 95d8a1eView commit details
Commits on Oct 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for efe8fa3 - Browse repository at this point
Copy the full SHA efe8fa3View commit details
Commits on Oct 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5c962a2 - Browse repository at this point
Copy the full SHA 5c962a2View commit details
Commits on Oct 22, 2023
-
Allow running persistent run hooks of all parents (spf13#2044)
Currently, only one of the persistent pre-runs and post-runs is executed. It is always the first one found in the parents chain, starting at this command. Expected behavior is to execute all parents' persistent pre-runs and post-runs. Dependent projects implemented various workarounds for this: - manually building persistent hook chains (in every hook). - applying some kind of monkey-patching on top of Cobra. This change eliminates the necessity for such workarounds by allowing to set a global variable EnableTraverseRunHooks. Tickets: - spf13#216 - spf13#252 Signed-off-by: Volodymyr Khoroz <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4cafa37 - Browse repository at this point
Copy the full SHA 4cafa37View commit details
Commits on Oct 27, 2023
-
Fix linter errors (spf13#2052)
When using golangci-lint v1.55.0 some new errors were being reported. Signed-off-by: Marc Khouzam <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8b1eba4 - Browse repository at this point
Copy the full SHA 8b1eba4View commit details
Commits on Oct 28, 2023
-
Don't complete --help flag when flag parsing disabled (spf13#2061)
Fixes spf13#2060 When a command sets `DisableFlagParsing = true` it requests the responsibility of doing all the flag parsing. Therefore even the `--help/-f/--version/-v` flags should not be automatically completed by Cobra in such a case. Without this change the `--help/-h/--version/-v` flags can end up being completed twice for plugins: one time from cobra and one time from the plugin (which has set `DisableFlagParsing = true`). Signed-off-by: Marc Khouzam <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b711e87 - Browse repository at this point
Copy the full SHA b711e87View commit details -
Add tests for flag completion registration (spf13#2053)
Different problems have been reported about flag completion registration. These two tests are the cases that were not being verified but had been mentioned as problematic. Ref: - spf13#1320 - spf13#1438 (comment) Signed-off-by: Marc Khouzam <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 00b68a1 - Browse repository at this point
Copy the full SHA 00b68a1View commit details
Commits on Oct 29, 2023
-
Replace all non-alphanumerics in active help env var program prefix (s…
…pf13#1940) * Replace all non-alphanumerics in active help env var program prefix There are other characters besides the dash that are fine in program names, but are problematic in environment variable names. These include (but are not limited to) period, space, and non-ASCII letters. * Another change in docs to mention non-ASCII-alphanumeric instead of just dash
Configuration menu - View commit details
-
Copy full SHA for 22953d8 - Browse repository at this point
Copy the full SHA 22953d8View commit details
Commits on Oct 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 48cea5c - Browse repository at this point
Copy the full SHA 48cea5cView commit details
Commits on Nov 2, 2023
-
Support usage as plugin for tools like kubectl (spf13#2018)
In this case the executable is `kubectl-plugin`, but we run it as: kubectl plugin And the help text should reflect the actual usage of the command. To create a plugin, add the cobra.CommandDisplayNameAnnotation: rootCmd := &cobra.Command{ Use: "plugin", Annotations: map[string]string{ cobra.CommandDisplayNameAnnotation: "kubectl plugin", } } Internally this change modifies CommandPath() for the root command to return the command display name instead of the command name. This is used for error messages, help text generation, and completions. CommandPath() is expected to have spaces and code using it already handle spaces (e.g replacing with _), so hopefully this does not break anything. Fixes: spf13#2017 Signed-off-by: Nir Soffer <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 890302a - Browse repository at this point
Copy the full SHA 890302aView commit details -
Improve API to get flag completion function (spf13#2063)
The new API is simpler and matches the `c.RegisterFlagCompletionFunc()` API. By removing the global function `GetFlagCompletion()` we are more future proof if we ever move from a global map of flag completion functions to something associated with the command. The commit also makes this API work with persistent flags by using `c.Flag(flagName)` instead of `c.Flags().Lookup(flagName)`. The commit also adds unit tests. Signed-off-by: Marc Khouzam <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a0a6ae0 - Browse repository at this point
Copy the full SHA a0a6ae0View commit details
Commits on Mar 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bfd8d9b - Browse repository at this point
Copy the full SHA bfd8d9bView commit details