-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for path mapping of error messages #113
Open
pepamartinec
wants to merge
14
commits into
formapro:master
Choose a base branch
from
usetreno:error-path
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[1.2] Fixed travis build & some improvements
Fixed validation_groups when option is a Closure formapro#93
- Added Symfony 2.6 to travis configuration - Support for IsFalse/IsTrue/IsNull - Testcase of multiplechoice less strict - valid filename of generated screenshot on Windows
Updated 1.2 to support Symfony 2.6 & 2.7
- PHP7 compatibility - Normalized multi choice behavior with 2.5.5+ - Minimum symfony version set to 2.7 - Updated JsFormValidatorFactory to return Choice(s)ToBooleanArrayTransformer transformer in case of expanded choice.
1.3 - Symfony 2.7 & 2.8
* Skip disabled fields * Clear previous errors for disabled fields
* Pass whole type hierarchy to model * Fix array construction (PHP 5.3 compatibility)
@Joker806 It looks messy. Can you update it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables validators to map error message to form element children. Its equivalent of Symfonys
ConstraintViolationBuilder->atPath()
.PHP example:
JS counterpart
The validator is now expected to return instances of
FpJsFormError
. If string is returned, it is automatically converted toFpJsFormError
to keep backward compatibility with existing validators.Internally, implementation keeps concept of error
sourceId
. It just recursively delegates error messages to element children.