Preserve original submit button #131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as submitted with
richard-ejem
force-pushed
the
fix-sending-submit-button
branch
2 times, most recently
from
4b74b55
to
dceecf4
Compare
henryfoster
approved these changes
Sep 23, 2020
|
Pleas look on the tests they are falling on you realization. |
Thanks for the feedback, but honestly I did this 3 years ago, now I don't even do PHP much anymore and this PR is completely out of my interest now, so I'm not willing to spend any more time with it. I don't even know if the issue is still present in latest version. If you look at the test results, it seems the test setup is completely broken and it is obviously nothing that could be caused by the PR. It is very likely that if the PR is still valid, just rebasing on current master where tests work will fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the button clicked to submit the form is not preserved and therefore not included in the request sent to server, because this package calls
event.preventDefault, then, if the form is valid, sendsform.submit(). This PR fixes the problem.