This repository has been archived by the owner on May 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 53
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
2 changed files
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4c70d84
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the upgrade to 1.6.0 caused issues with usage in browser due to missing default export on intl-messageformat-parser when used from intl-messageformat
I was able to fix this by removing the line
"browser": "lib/parser.js",
from package.json - which resulted in index.js adding the default to the /lib/parser.js version4c70d84
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
intl-messageformat
dependency onintl-messageformat-parser
is still hardcoded at1.4.0
but thanks a lot for raising this. Do you mind creating a Github issue so we can track this?4c70d84
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I see that, although
babel-plugin-react-intl
is not pegged to1.4.0
so for me at least this breaks. Have forced downgrade for now, will add an issue