Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9758: fixed an issue where interpolated content data is not displayed in PDF download #6035

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

TanyaGashtold
Copy link
Contributor

@TanyaGashtold TanyaGashtold commented Mar 3, 2025

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9758

Description

What changed?

When the submission is rendered is PDF format, the formio-viewer sets the submission and after that waits until the dataReady promise is resolved. It appears that the dataReady promise is resolved for nested forms before the data is actually set because the data is considered to be ready when the subFormReady promise is resolved. Because of it, the pdf file can be generated before all submission data is correctly set and displayed.
This PR makes it so that the nested form data is considered to be ready when the subForm data is ready. This allows to wait until all nested form data is set and only after that the PDF is generated.

How has this PR been tested?

Manually + tests

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant