Skip to content

Fio 9942 protected eval extends default eval #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Maria-Golomb
Copy link

@Maria-Golomb Maria-Golomb commented Aug 7, 2025

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9942

Description

DefaultEvaluator extends DefaultEvaluator (@formio/js).
I prefer to make ProtectedEvaluator class inherit from the DefaultEvaluator (@formio/js) instead Core Evaluator class (@formio/core) because in case of Core Evaluator for correct work ProtectedEvaluator should be expanded with functionality that is already contain in DefaultEvaluator.

TypeScript compiler target updated from es5 to es6 for compatibility with render 5.x.

Breaking Changes / Backwards Compatibility

Dependencies

for correct work should use @formio/js with:
formio/formio.js#6208

How has this PR been tested?

manually

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant