Adding more tests for ML-DSA-44.

tests/ml_dsa_wrapper.py

@@ -70,9 +70,15 @@ def sign(self, signing_key, message, randomness):
     def verify(self, verification_key, message, signature):
         if self.parameter_set == "44":
             return self.ml_dsa.ml_dsa_44_verify(
-                verification_key, self.bytearray_to_ctype(message), len(message), signature
+                verification_key,
+                self.bytearray_to_ctype(message),
+                len(message),
+                signature,
             )
         elif self.parameter_set == "65":
             return self.ml_dsa.ml_dsa_65_verify(
-                verification_key, self.bytearray_to_ctype(message), len(message), signature
+                verification_key,
+                self.bytearray_to_ctype(message),
+                len(message),
+                signature,
             )

tests/test_accumulated_kats.py

@@ -7,7 +7,9 @@
 
 @pytest.fixture()
 def expected_final_hash(ml_dsa):
-    if ml_dsa.parameter_set == "65":
+    if ml_dsa.parameter_set == "44":
+        return "6a9b0e409516b34c706e2abaae5441b10baae85e98e3fafba5b25d864fe2b0aa"
+    elif ml_dsa.parameter_set == "65":
         return "8fc42bd9a915e5d5b5b7be9d1f882034c80c55e1f1b61b37af670635e7db1b64"
 
 

tests/test_nist_drbg_kats.py

@@ -16,7 +16,7 @@ def kats(ml_dsa):
         return json.load(kats_raw)
 
 
-def test_against_kats(ml_dsa, kats):
+def test_against_nist_drbg_kats(ml_dsa, kats):
     for kat in kats:
         # Test key generation.
         key_generation_seed = bytearray.fromhex(kat["key_generation_seed"])

tests/test_pqc_kats.py

@@ -14,7 +14,7 @@ def kats(ml_dsa):
         return json.load(kats_raw)
 
 
-def test_against_kats(ml_dsa, kats):
+def test_against_pqc_kats(ml_dsa, kats):
     for kat in kats:
         # Test key generation.
         key_generation_seed = bytearray.fromhex(kat["key_generation_seed"])
@@ -34,9 +34,6 @@ def test_against_kats(ml_dsa, kats):
 
         # Then signing.
 
-        # We append [0,0] to signal an empty domain separation context, see
-        # the comment in ml_dsa.jazz for as to why this is done here instead
-        # of there.
         ctx = bytearray.fromhex(kat["context"])
         message = bytearray([0, len(ctx)]) + ctx + bytearray.fromhex(kat["message"])
 
@@ -47,7 +44,7 @@ def test_against_kats(ml_dsa, kats):
         sha3_256_hash_of_signature = hashlib.sha3_256(signature).digest()
         assert sha3_256_hash_of_signature == bytes.fromhex(
             (kat["sha3_256_hash_of_signature"])
-        )
+        ), print("Failure at KAT number {}".format(kat["count"]))
 
         # And lastly, verification.
         verification_result = ml_dsa.verify(verification_key.raw, message, signature)

tests/test_wycheproof.py

@@ -26,7 +26,7 @@ def verification_test_groups(ml_dsa):
         return json.load(tests_raw)["testGroups"]
 
 
-def test_signing(ml_dsa, signing_test_groups):
+def test_wycheproof_sign(ml_dsa, signing_test_groups):
     signing_seed = bytearray([0] * 32)
 
     for test_group in signing_test_groups:
@@ -72,7 +72,7 @@ def test_signing(ml_dsa, signing_test_groups):
             # wycheproof test file.
 
 
-def test_verification(ml_dsa, verification_test_groups):
+def test_wycheproof_verify(ml_dsa, verification_test_groups):
     for test_group in verification_test_groups:
         verification_key = bytearray.fromhex(test_group["publicKey"])
         if len(verification_key) != ml_dsa.verification_key_size: