Skip to content

Commit

Permalink
Use git snapshot of wasm-bindgen
Browse files Browse the repository at this point in the history 
See cloudflare/workers-rs#668
  • Loading branch information
@fornwall
fornwall committed Nov 28, 2024
1 parent 28b66f1 commit 51053cb
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ jobs:
- name: Install wasm-opt
run: brew update && brew install binaryen
- run: curl -L --proto '=https' --tlsv1.2 -sSf https://raw.githubusercontent.com/cargo-bins/cargo-binstall/main/install-from-binstall-release.sh | bash
- run: cargo binstall --no-confirm wasm-bindgen-cli
- run: cargo install wasm-bindgen-cli --git https://github.com/rustwasm/wasm-bindgen
- name: Test with Node ${{ matrix.node-version }}
run: make node-package

Expand Down Expand Up @@ -368,6 +368,7 @@ jobs:
- uses: Homebrew/actions/setup-homebrew@master
- name: Install wasm-opt
run: brew update && brew install binaryen
- run: cargo install wasm-bindgen-cli --git https://github.com/rustwasm/wasm-bindgen
- name: Deploy to Cloudflare
env:
CLOUDFLARE_API_TOKEN: ${{ secrets.CLOUDFLARE_API_TOKEN }}
Expand Down
6 changes: 6 additions & 0 deletions Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,9 @@ cargo = { level = "deny", priority = -1 }
nursery = { level = "deny", priority = -1 }
# Individual lints:
new_without_default = "allow"

[patch.crates-io]
wasm-bindgen = { git = "https://github.com/rustwasm/wasm-bindgen" }
wasm-bindgen-shared = { git = "https://github.com/rustwasm/wasm-bindgen" }
wasm-bindgen-backend = { git = "https://github.com/rustwasm/wasm-bindgen" }
wasm-bindgen-macro-support = { git = "https://github.com/rustwasm/wasm-bindgen" }

1 comment on commit 51053cb

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

@@                     Benchmark Difference                     @@
#      Name   Old (instructions)   New (instructions)   Change (%)
   2023_1_1            1,484,904            1,484,904            0
   2023_1_2            1,457,486            1,457,486            0
   2023_2_1              565,166              565,166            0
   2023_2_2              538,291              538,291            0
   2023_3_1              831,300              831,300            0
   2023_3_2              627,081              627,081            0
   2023_4_1              911,485              911,485            0
   2023_4_2              922,701              922,701            0
   2023_5_1              638,297              638,297            0
   2023_5_2              773,139              773,139            0
   2023_6_1                3,686                3,686            0
   2023_6_2                2,655                2,655            0
   2023_7_1              661,073              661,073            0
   2023_7_2              657,249              657,249            0
   2023_8_1            1,174,661            1,174,661            0
   2023_8_2            2,580,225            2,580,225            0
   2023_9_1              799,599              799,599            0
   2023_9_2              811,324              811,324            0
  2023_10_1            2,950,347            2,950,347            0
  2023_10_2            3,513,752            3,513,752            0
  2023_11_1            1,741,784            1,741,784            0
  2023_11_2            1,741,808            1,741,808            0
  2023_12_1            4,374,269            4,374,269            0
  2023_12_2           68,540,595           68,540,595            0
  2023_13_1              583,261              583,261            0
  2023_13_2              584,317              584,317            0
  2023_14_1              839,816              839,816            0
  2023_14_2          289,510,494          289,510,494            0
  2023_15_1              807,775              807,775            0
  2023_15_2            1,087,804            1,087,804            0
  2023_16_1            1,074,611            1,074,611            0
  2023_16_2          220,130,028          220,130,028            0
  2023_17_1          216,844,222          216,844,222            0
  2023_17_2          666,065,705          666,065,705            0
  2023_18_1              368,082              368,082            0
  2023_18_2              438,373              438,373            0
  2023_19_1            3,006,454            3,006,454            0
  2023_19_2            1,918,778            1,918,778            0
  2023_20_1            4,637,735            4,637,735            0
  2023_20_2           18,235,147           18,235,147            0
  2023_21_1            3,137,778            3,137,778            0
  2023_21_2            4,545,451            4,545,451            0
  2023_22_1           10,749,692           10,749,692            0
  2023_22_2          291,836,479          291,836,479            0
  2023_23_1            1,693,610            1,693,610            0
  2023_23_2        1,129,554,270        1,129,554,270            0
  2023_24_1            3,666,389            3,666,389            0
  2023_24_2              982,493              982,493            0
  2023_25_1            2,376,198            2,376,198            0
Benchmark Instructions (count) Instructions (%)
2023_23_2 1,129,554,270 38.0
2023_17_2 666,065,705 22.4
2023_22_2 291,836,479 9.8
2023_14_2 289,510,494 9.7
2023_16_2 220,130,028 7.4
2023_17_1 216,844,222 7.3
2023_12_2 68,540,595 2.3
2023_20_2 18,235,147 0.6
2023_22_1 10,749,692 0.4
2023_20_1 4,637,735 0.2
2023_21_2 4,545,451 0.2
2023_12_1 4,374,269 0.1
2023_24_1 3,666,389 0.1
2023_10_2 3,513,752 0.1
2023_21_1 3,137,778 0.1
2023_19_1 3,006,454 0.1
2023_10_1 2,950,347 0.1
2023_8_2 2,580,225 0.1
2023_25_1 2,376,198 0.1
2023_19_2 1,918,778 0.1
2023_11_2 1,741,808 0.1
2023_11_1 1,741,784 0.1
2023_23_1 1,693,610 0.1
2023_1_1 1,484,904 0.0
2023_1_2 1,457,486 0.0
2023_8_1 1,174,661 0.0
2023_15_2 1,087,804 0.0
2023_16_1 1,074,611 0.0
2023_24_2 982,493 0.0
2023_4_2 922,701 0.0
2023_4_1 911,485 0.0
2023_14_1 839,816 0.0
2023_3_1 831,300 0.0
2023_9_2 811,324 0.0
2023_15_1 807,775 0.0
2023_9_1 799,599 0.0
2023_5_2 773,139 0.0
2023_7_1 661,073 0.0
2023_7_2 657,249 0.0
2023_5_1 638,297 0.0
2023_3_2 627,081 0.0
2023_13_2 584,317 0.0
2023_13_1 583,261 0.0
2023_2_1 565,166 0.0
2023_2_2 538,291 0.0
2023_18_2 438,373 0.0
2023_18_1 368,082 0.0
2023_6_1 3,686 0.0
2023_6_2 2,655 0.0

Please sign in to comment.