-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON-RPC local cache for v2 bots #855
Merged
dkeysil
merged 9 commits into
master
from
kisel/forta-1609-accept-json-rpc-cache-requests-from-bots
Apr 2, 2024
Merged
JSON-RPC local cache for v2 bots #855
dkeysil
merged 9 commits into
master
from
kisel/forta-1609-accept-json-rpc-cache-requests-from-bots
Apr 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dkeysil
commented
Mar 8, 2024
•
edited
Loading
edited
- One more HTTP server inside json-rpc-proxy
- Polls combined block events from the Dispatcher as a R2 links
- Transforms proto CBE to jsonrpc structures
- Keeps hot in memory cache for different chains
- Garbage collection for the cache
- Authorization and Chain ID extraction from http header
dkeysil
force-pushed
the
kisel/forta-1609-accept-json-rpc-cache-requests-from-bots
branch
3 times, most recently
from
March 11, 2024 16:31
092a5d7
to
c28a758
Compare
aomerk
reviewed
Mar 12, 2024
aomerk
reviewed
Mar 12, 2024
aomerk
reviewed
Mar 12, 2024
canercidam
reviewed
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great overall! We could polish it a little more.
dkeysil
force-pushed
the
kisel/forta-1609-accept-json-rpc-cache-requests-from-bots
branch
from
March 12, 2024 15:12
482c8fc
to
c82476b
Compare
dkeysil
force-pushed
the
kisel/forta-1609-accept-json-rpc-cache-requests-from-bots
branch
from
March 15, 2024 10:17
c33cbbd
to
2f3b2a9
Compare
dkeysil
force-pushed
the
kisel/forta-1609-accept-json-rpc-cache-requests-from-bots
branch
from
March 15, 2024 15:56
927c56f
to
f83bc1d
Compare
dkeysil
force-pushed
the
kisel/forta-1609-accept-json-rpc-cache-requests-from-bots
branch
from
March 21, 2024 08:09
f83bc1d
to
ed41b8c
Compare
Add cache test Add json rpc cache to executable Make cache config optional, debug logs in cache, fix dispatcher url path Refactor json rpc cache Fix cache keys Use mappers from the forta-core-go Move jsonrpc changes of proxy to cache package Tweak events polling in cache Use go-cache package Rename cbe (Combined Block Event) to BlockData Add retries to r2_client Check 404 error body, check if node has assigned bots Inject sdk cache configuration to agents Refactor Fix registry usage Add logging Update forta-core-go Metrics draft Fix nil panic Fix params string Add log on cache miss Improve polling Increase bucket time if no bots assigned Decrease max backoff to 10 seconds Fix bug in r2 client Retry on 'Block too old' Clean metrics in jsonrpc cache
dkeysil
force-pushed
the
kisel/forta-1609-accept-json-rpc-cache-requests-from-bots
branch
from
March 22, 2024 17:36
b2a8133
to
2d6c53a
Compare
canercidam
approved these changes
Apr 2, 2024
aomerk
approved these changes
Apr 2, 2024
dkeysil
deleted the
kisel/forta-1609-accept-json-rpc-cache-requests-from-bots
branch
April 2, 2024 09:23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.