Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

60 format option to match buf or rvls #314

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

UmeSiyah
Copy link

@UmeSiyah UmeSiyah commented Nov 4, 2024

Hello,

This is a draft MR to have some feedback on the code until I finish to update the documentation

move concat

clean test

fix: fix rebase

linter: add allow dead code

alllow dead code
@UmeSiyah UmeSiyah marked this pull request as draft November 4, 2024 18:02
@doubleailes doubleailes added the enhancement New feature or request label Nov 5, 2024
@UmeSiyah UmeSiyah force-pushed the WIP-60-format-option-to-match-buf-or-rvls branch 5 times, most recently from fce0538 to 55dbfec Compare November 12, 2024 07:30
@UmeSiyah UmeSiyah force-pushed the WIP-60-format-option-to-match-buf-or-rvls branch from 55dbfec to 562e135 Compare November 12, 2024 07:31
@UmeSiyah
Copy link
Author

UmeSiyah commented Nov 12, 2024

Hello,

I cleaned my commits and add all documentation. I remove de draft of this PR. I'll add some details of what I did in this comment to helping the review.

P.S. : I'm changing my Frames struct to use the function group_continuity, so don't pay attention to the dead_code warning

     Running `target\debug\fls.exe --format buf .\samples\uncontinu\`
aaa.[1:3,5:5,15:16,19:20].tif

@UmeSiyah UmeSiyah marked this pull request as ready for review November 12, 2024 08:36
@UmeSiyah UmeSiyah changed the title Draft:60 format option to match buf or rvls 60 format option to match buf or rvls Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants