-
Notifications
You must be signed in to change notification settings - Fork 108
feat: shared
and static
library targets
#1138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
perazz
wants to merge
60
commits into
fortran-lang:main
Choose a base branch
from
perazz:dynamic_library
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,736
−244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re the building order, not only link flags
shared
library targetsshared
and static
library targets
…dynamic_library
cc: @zoziha |
zoziha
reviewed
May 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really complex. Thank you for your work, @perazz . Since all the tests have passed, I think this PR can be merged after waiting for potential review comments from others.
Additionally, I've left some comments.
zoziha
approved these changes
May 16, 2025
zoziha
reviewed
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Add support for building shared libraries via
[library]
type optionThis PR introduces a new manifest option to control how libraries are built:
Key features for
type = "shared"
:lib<package>.{so|dll|dylib}
)..so
on Linux,.dylib
on macOS,.dll + .lib + .def
on Windows.install.library = true
, shared libraries are installed to thelib/
directory.fpm run
automatically updatesLD_LIBRARY_PATH
(or platform equivalent) to find runtime libraries.📚 documentation available at fortran-lang/fpm-docs#164
Address #681 #655, Supersede #1050.
cc: @certik @urbanjost @arteevraina @henilp105