arc64: Update symbol-2.c to use strict function prototypes. #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the test case to declare separate functions with explicit prototypes: - `f1()` replaces the old K&R-style `f()` for calls with no arguments. - `f2(int,int,int,void*)` is used when passing a pointer to `_nl_C_locobj`. - `f3(int,int,int,struct s)` is used when passing `_nl_C_locobj` by value. This ensures the test compiles cleanly on GCC 15, preserving the `_nl_C_locobj` access patterns for the assembly scan. Signed-off-by: Luis Silva <[email protected]>
|
Ah, it's because of this: https://gcc.gnu.org/gcc-15/porting_to.html#c23-fn-decls-without-parameters |
MichielDerhaeg
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the test case to declare separate functions with explicit prototypes:
f1()replaces the old K&R-stylef()for calls with no arguments.f2(int,int,int,void*)is used when passing a pointer to_nl_C_locobj.f3(int,int,int,struct s)is used when passing_nl_C_locobjby value.This ensures the test compiles cleanly on GCC 15, preserving the
_nl_C_locobjaccess patterns for the assembly scan.Thanks for taking the time to contribute to GCC! Please be advised that if you are
viewing this on
github.com, that the mirror there is unofficial and unmonitored.The GCC community does not use
github.comfor their contributions. Instead, we usea mailing list (
[email protected]) for code submissions, code reviews, andbug reports. Please send patches there instead.