Form-Data and multi-part request feature added #101

vidya-hub · 2023-12-20T17:00:01Z

Multi-Part Request Feature #92,#91

Added form-data option in request body content type.
now we can select text or file type in form-data fields and send multi-part Request.
Form-Data can be Saved in Local DB and can Load from the saved data.
Added multipart Code generation feature for all supported languages in the Code Gen DropDown

ashitaprasad · 2023-12-22T03:33:46Z

lib/consts.dart

 import 'package:flutter/foundation.dart';
 import 'package:flutter/material.dart';
 import 'package:google_fonts/google_fonts.dart';
-import 'package:davi/davi.dart';



Feedback in regards to import across all the files.
Please revert all import re-arrangements that have been done as they are introducing non-essential code changes.
Only add new import lines or modify existing lines.

ashitaprasad · 2023-12-22T03:33:54Z

lib/consts.dart

@@ -294,6 +298,15 @@ const kSubTypeDefaultViewOptions = 'all';
 const kContentTypeMap = {
  ContentType.json: "$kTypeApplication/$kSubTypeJson",
  ContentType.text: "$kTypeText/$kSubTypePlain",
+  ContentType.formdata: "multipart/form-data",
+};
+const kFormDataTypeMap = {


kFormDataTypeMap & kMapFormDataType can be avoided if FormDataType is structured as CodegenLanguage

ashitaprasad · 2023-12-22T03:34:17Z

lib/utils/convert_utils.dart

-import '../models/models.dart';
+import 'dart:typed_data';
+
+import 'package:apidash/models/form_data_model.dart';


it should already be imported via '../models/models.dart'

ashitaprasad · 2023-12-22T03:40:14Z

lib/services/http_service.dart

@@ -63,3 +65,59 @@ Future<(http.Response?, Duration?, String?)> request(
    return (null, null, uriRec.$2);
  }
 }
+
+Future<(http.Response?, Duration?, String?)> multiPartRequest(


Can the existing function be modified to support multipart using a multipart = true argument

lib/services/http_service.dart

ashitaprasad · 2023-12-22T04:01:46Z

Thanks for the PR @vidya-hub
Apart from the comments mentioned above. PFA a few more observations.

There are overflow issues. It should be along the lines of params and headers which have an empty default row in the beginning and the user is able to clear the first row (which gets replaced by an empty row) if it is the only row. Please play around with headers & params to better understand the behaviour.

Also, the color scheme of the file picker widget (purple) is not following the color theme of API Dash.

vidya-hub · 2023-12-22T10:06:21Z

Hi @ashitaprasad

Thanks for your comments and observations.
Sure I will work on those things and once it is done I will push the code changes.

Thank you.

ashitaprasad · 2023-12-25T18:01:08Z

lib/consts.dart

@@ -48,6 +48,10 @@ const kHintOpacity = 0.6;
 const kForegroundOpacity = 0.05;

 const kTextStyleButton = TextStyle(fontWeight: FontWeight.bold);
+const kFormDataButton = TextStyle(


kFormDataButton -> kFormDataButtonLabelTextStyle

ashitaprasad · 2023-12-25T18:11:48Z

Hi @vidya-hub
I have reviewed the PR. There are still pending issues that you need to fix that I pointed out in the earlier review.

vidya-hub · 2023-12-25T18:17:41Z

Hey @ashitaprasad

Thank you

Can you tell me which issues I've missed so that i can give a fix for that

ashitaprasad · 2023-12-25T18:34:10Z

Sure @vidya-hub

This comment and this comment

…into form_data_imp

ashitaprasad · 2023-12-27T16:03:59Z

lib/providers/collection_providers.dart

+    (http.Response?, Duration?, String?)? responseRec = await request(
+      requestModel,
+      defaultUriScheme: defaultUriScheme,
+      isMultiPartRequest: requestModel.formDataList != null &&


requestBodyContentType is the correct way to determine the value of isMultiPartRequest.

ashitaprasad · 2023-12-27T16:06:18Z

lib/screens/home_page/collection_pane.dart

@@ -108,36 +108,40 @@ class _RequestListState extends ConsumerState<RequestList> {
      controller: controller,


Revert this change which has nothing to do with formdata & we already show a full page message in details pane when there is no request.

ashitaprasad · 2023-12-27T16:07:11Z

lib/screens/home_page/editor_pane/details_card/request_pane/request_body.dart

@@ -3,6 +3,7 @@ import 'package:flutter_riverpod/flutter_riverpod.dart';
 import 'package:apidash/providers/providers.dart';
 import 'package:apidash/widgets/widgets.dart';
 import 'package:apidash/consts.dart';
+import 'package:apidash/widgets/form_data_widget.dart';


Add form_data_widget.dart to widgets.dart which is already imported.

ashitaprasad · 2023-12-27T16:07:56Z

lib/screens/home_page/editor_pane/details_card/request_pane/request_body.dart

@@ -12,12 +13,21 @@ class EditRequestBody extends ConsumerStatefulWidget {
 }

 class _EditRequestBodyState extends ConsumerState<EditRequestBody> {
+  @override


Remove as you are not doing anything inside initState()

ashitaprasad · 2024-01-07T09:24:22Z

@vidya-hub I have made some changes to the PR.
Can you go through it once and test it out.

vidya-hub · 2024-01-07T09:32:24Z

Sure @ashitaprasad

Form data code gen merge

vidya-hub · 2024-01-07T09:48:18Z

@ashitaprasad

I've gone through the changes and tested it everything is working fine in form-data side.
Thanks.

ashitaprasad · 2024-01-07T10:48:18Z

Hi @vidya-hub,
I have fixed some tests.
But, currently js & nodejs codegen tests are failing. This might be because of the lack of check in the codegens for the presence of any form data.
Kindly, run flutter test to see the detailed test results and kindly fix the codegens.
Thanks!

vidya-hub · 2024-01-07T10:49:38Z

Thank you @ashitaprasad

I will check and update.

chore: fixed code generation test cases

vidya-hub · 2024-01-07T14:07:20Z

Hi @ashitaprasad
I've fixed all flutter-test-related issues and all tests are passed can you please check once.

Thanks!

ashitaprasad · 2024-01-07T14:08:00Z

Sure @vidya-hub 👍

chore: fixed spacing issues in nodejs axios codegen

ashitaprasad · 2024-01-07T14:27:59Z

@vidya-hub Since you are not adding any new test cases for multipart forms, please make changes only to the codegen codes and revert any changes made to the expected codes (even spacings) given in the test files.
These expected codes are golden tests that have already been run, verified and formatted properly.

vidya-hub · 2024-01-07T14:33:47Z

Sure @ashitaprasad

vidya-hub · 2024-01-07T14:50:10Z

Hi @ashitaprasad

test/models/request_model_test.dart

can you please check this file in PR once

ashitaprasad · 2024-01-07T14:52:49Z

@vidya-hub test/models/request_model_test.dart will only change as the model has been changed.
I was talking about the codegen test cases that contain the expected code.

rev: reverted changes in js code gen

vidya-hub · 2024-01-07T14:57:00Z

Thank you,
Understood @ashitaprasad.

I've pushed the changes,
can you please check once .

ashitaprasad · 2024-01-07T14:58:01Z

Sure @vidya-hub 👍

ashitaprasad · 2024-01-07T15:27:36Z

@vidya-hub There was a minor issue with python codegen which I have fixed.
LGTM. It is ready for merge 🚀
The only thing remaining is adding codegen tests for this feature which we can add in a separate PR once I open an issue & assign it to you after figuring out a good public endpoint.
Thanks for the awesome PR 🙌

vidya-hub · 2024-01-07T15:31:13Z

Thanks a lot @ashitaprasad

Sure I am working on it already.

Thank you for your comments and suggestions.
I've learnt a lot from you by implementing this feature.

ashitaprasad · 2024-01-07T15:37:08Z

@vidya-hub
It was a blast working with you on this valuable PR! 🎉
Definitely looking forward to more contributions from you 🤘
Don't forget to share this wonderful open source achievement on your socials (Twitter, LinkedIn). 🥳

vidya-hub · 2024-01-07T16:38:14Z

Thank you @ashitaprasad.

Sure 😊

vidya-hub and others added 6 commits December 19, 2023 20:55

wip: added basic methods

e1ae22b

wip: added necessary function to pick the files

ffb9681

feat: Multi Part Request Feature Added

c04507f

chore: added imports for multi part request

a9bbe20

chore: reverted name value model files

906cf83

Merge branch 'main' into form_data_imp

b320090

animator added the under review label Dec 21, 2023

ashitaprasad reviewed Dec 22, 2023

View reviewed changes

ashitaprasad added work in progress Dev team is already working on this issue and removed under review labels Dec 22, 2023

vidya-hub added 8 commits December 23, 2023 22:47

fix: PR fixes with few enhancements

1444317

chore: reverted name view model

35c0ed3

chore: imports reorder

57aca1b

chore: name value revert

22677d5

req model imports

784b894

hive services revert

7df0923

file ext deleted

a4765e0

Merge branch 'main' into form_data_imp

513243e

ashitaprasad reviewed Dec 25, 2023

View reviewed changes

vidya-hub added 2 commits December 27, 2023 21:25

fix: fixes for alignment issues and request handling methods

880f445

Merge branch 'form_data_imp' of https://github.com/vidya-hub/apidash …

6ba4197

…into form_data_imp

ashitaprasad reviewed Dec 27, 2023

View reviewed changes

vidya-hub added 2 commits January 7, 2024 15:12

fix: curl gen issue fixes

5153841

Merge pull request #2 from vidya-hub/form_data_code_gen

7d5c0b4

Form data code gen merge

ashitaprasad added 2 commits January 7, 2024 15:50

Merge branch 'main' into form_data_imp

37ec266

Fix tests

30791df

vidya-hub added 2 commits January 7, 2024 19:32

chore: fixed code generation test cases

b532044

Merge pull request #3 from vidya-hub/form_data_code_gen

d0114a6

chore: fixed code generation test cases

vidya-hub added 2 commits January 7, 2024 19:50

chore: fixed spacing issues in nodejs axios codegen

9d8379e

Merge pull request #4 from vidya-hub/form_data_code_gen

673668e

chore: fixed spacing issues in nodejs axios codegen

rev: reverted changes in js code gen

fe3bea3

Merge pull request #5 from vidya-hub/form_data_code_gen

6959867

rev: reverted changes in js code gen

Fix python codegens

b92ac78

ashitaprasad merged commit 252b014 into foss42:main Jan 7, 2024

ashitaprasad removed the under review label Jan 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Form-Data and multi-part request feature added #101

Form-Data and multi-part request feature added #101

vidya-hub commented Dec 20, 2023 •

edited

Loading

ashitaprasad Dec 22, 2023

ashitaprasad Dec 22, 2023

ashitaprasad Dec 22, 2023

ashitaprasad Dec 22, 2023

ashitaprasad commented Dec 22, 2023

vidya-hub commented Dec 22, 2023

ashitaprasad Dec 25, 2023

ashitaprasad commented Dec 25, 2023

vidya-hub commented Dec 25, 2023

ashitaprasad commented Dec 25, 2023

ashitaprasad Dec 27, 2023

ashitaprasad Dec 27, 2023

ashitaprasad Dec 27, 2023

ashitaprasad Dec 27, 2023

ashitaprasad commented Jan 7, 2024

vidya-hub commented Jan 7, 2024

vidya-hub commented Jan 7, 2024 •

edited

Loading

ashitaprasad commented Jan 7, 2024

vidya-hub commented Jan 7, 2024

vidya-hub commented Jan 7, 2024

ashitaprasad commented Jan 7, 2024

ashitaprasad commented Jan 7, 2024 •

edited

Loading

vidya-hub commented Jan 7, 2024

vidya-hub commented Jan 7, 2024

ashitaprasad commented Jan 7, 2024

vidya-hub commented Jan 7, 2024

ashitaprasad commented Jan 7, 2024

ashitaprasad commented Jan 7, 2024

vidya-hub commented Jan 7, 2024

ashitaprasad commented Jan 7, 2024

vidya-hub commented Jan 7, 2024

		@@ -108,36 +108,40 @@ class _RequestListState extends ConsumerState<RequestList> {
		controller: controller,

Form-Data and multi-part request feature added #101

Form-Data and multi-part request feature added #101

Conversation

vidya-hub commented Dec 20, 2023 • edited Loading

**Multi-Part Request Feature #92,#91 **

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ashitaprasad commented Dec 22, 2023

vidya-hub commented Dec 22, 2023

Choose a reason for hiding this comment

ashitaprasad commented Dec 25, 2023

vidya-hub commented Dec 25, 2023

ashitaprasad commented Dec 25, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ashitaprasad commented Jan 7, 2024

vidya-hub commented Jan 7, 2024

vidya-hub commented Jan 7, 2024 • edited Loading

ashitaprasad commented Jan 7, 2024

vidya-hub commented Jan 7, 2024

vidya-hub commented Jan 7, 2024

ashitaprasad commented Jan 7, 2024

ashitaprasad commented Jan 7, 2024 • edited Loading

vidya-hub commented Jan 7, 2024

vidya-hub commented Jan 7, 2024

ashitaprasad commented Jan 7, 2024

vidya-hub commented Jan 7, 2024

ashitaprasad commented Jan 7, 2024

ashitaprasad commented Jan 7, 2024

vidya-hub commented Jan 7, 2024

ashitaprasad commented Jan 7, 2024

vidya-hub commented Jan 7, 2024

vidya-hub commented Dec 20, 2023 •

edited

Loading

Multi-Part Request Feature #92,#91

vidya-hub commented Jan 7, 2024 •

edited

Loading

ashitaprasad commented Jan 7, 2024 •

edited

Loading