Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes Sync url and params tab issue #226

Closed
wants to merge 2 commits into from

Conversation

amankumarmahavar
Copy link

PR Description

This pull request enables the synchronization of the URL with URL parameters and vice versa

Recording.2024-02-28.232524.mp4

Related Issues

Checklist

  • I have gone through the contributing guide
  • I have run the tests (flutter test) and all tests are passing

Added/updated tests?

We encourage you to add relevant test cases.

  • Yes
  • No, and this is why: please replace this line with details on why tests have not been included
  • I need help with writing tests

@opxdelwin
Copy link
Contributor

Hey, quick question, does it go the other way around? i.e, If a URL with query params are pasted/typed directly into the URLField, does the params tab update as per?

@amankumarmahavar
Copy link
Author

Yes its working

Recording.2024-02-28.232524.mp4

@opxdelwin
Copy link
Contributor

I see few commented lines making it into the PR, it'd be easier for maintainers if you could remove em' beforehand. The approach looks solid! 🚀

@amankumarmahavar
Copy link
Author

Surely will consider the remark...

@ashitaprasad
Copy link
Member

Refer #166 (comment)

@animator animator closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync url and params tab
4 participants