Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: desktop responsiveness #408

Merged

Conversation

DenserMeerkat
Copy link
Contributor

@DenserMeerkat DenserMeerkat commented Jun 9, 2024

PR Description

Make switching between the layouts based on available width & not specific to OS.

Related Issues

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have run the tests (flutter test) and all tests are passing

Added/updated tests?

We encourage you to add relevant test cases.

  • Yes
  • No, and this is why: Still a work in progress

@DenserMeerkat
Copy link
Contributor Author

Device width breakpoints chosen as mentioned in m3 docs

Haven't yet tested in MacOS and Linux

Known Issues:

  • Incorrect drawer widths when resizing
    image
    Possible fix - link (Still haven't fully looked into it)
  • Incorrect navigation:
    Opening View Code / Settings / About page in Compact View pushes a new page in to the navigation stack but in Expanded View it doesn't, hence issues when resizing these pages.
    Possible fix - Page navigation in compact view without pushing new page into stack.
  • Window Dragging in Compact View:
    Window Draggability not yet implemented in Compact View.

@DenserMeerkat DenserMeerkat changed the title feat: desktop responsiveness [WIP] feat: desktop responsiveness Jun 12, 2024
@DenserMeerkat DenserMeerkat marked this pull request as ready for review June 12, 2024 19:50
@ashitaprasad ashitaprasad linked an issue Jun 13, 2024 that may be closed by this pull request
@ashitaprasad ashitaprasad merged commit fe684e0 into foss42:main Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make app responsive
2 participants