client: Fix navigation regressions #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`state` belongs to the second argument. And we do not really need to spread the original location – `pathname` and `search` will be updated as needed, and we do not care about `hash`. This got broken in 88deede.
Avoid pushing an extra item to history so that back button works. This got broken in 88deede.
When an article is activated, its `id` will be appended to URL. `NavigateFunction` depends on `Location` so when the URL was updated, the `useEffect` callback would be triggered due to the dependency change. The callback would then reload the entries list. Even worse, when using the unread filter, the just activated entry would disappear. However, we should not actually need to pass the `navigate` function: The `Location` is really only a dependency so that `pathname: null` can use the current location, https://github.com/remix-run/react-router/blob/a3e4b8ed875611637357647fcf862c2bc61f4e11/packages/react-router/lib/router/utils.ts#L1267 and we always do set a string `pathname`. And the other dependencies appear to be static: https://github.com/remix-run/react-router/blob/a3e4b8ed875611637357647fcf862c2bc61f4e11/packages/react-router/lib/hooks.tsx#L292-L296 This got broken in 88deede.
✅ Deploy Preview for selfoss canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regressions from 88deede
Fixes: #1513