Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update position for do_not_record icon on schedule view #152

Merged
merged 18 commits into from
Jul 31, 2024

Conversation

lcduong
Copy link
Contributor

@lcduong lcduong commented Jul 30, 2024

Update position for do_not_record icon in schedule view.
image

Summary by Sourcery

Added the 'do_not_record' attribute to the schedule data model to include information about whether a talk should not be recorded.

Copy link

sourcery-ai bot commented Jul 30, 2024

Reviewer's Guide by Sourcery

This pull request updates the position for the 'do_not_record' icon on the schedule view by adding a new field to the schedule data model. The change involves modifying the build_data method in the schedule.py file to include the do_not_record attribute from the submission object.

File-Level Changes

Files Changes
src/pretalx/schedule/models/schedule.py Incorporated the 'do_not_record' attribute into the schedule data model to reflect its status in the schedule view.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lcduong - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@mariobehling
Copy link
Member

Please resolve conflicts.

@mariobehling
Copy link
Member

Please resolve conflicts.

@mariobehling mariobehling merged commit bcd02f3 into fossasia:development Jul 31, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants