Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance login screen options #159

Merged
merged 5 commits into from
Jul 31, 2024
Merged

Conversation

odkhang
Copy link
Contributor

@odkhang odkhang commented Jul 31, 2024

This PR closes/references issue #148 . It does so by using boostrap accordion in the auth.html

How has this been tested?

Checklist

  • I have added tests to cover my changes.

Summary by Sourcery

This pull request enhances the login screen by integrating a Bootstrap accordion to organize the login and registration forms, improving the user interface and experience.

  • Enhancements:
    • Replaced the existing login and registration forms with a Bootstrap accordion for better UI/UX on the authentication page.

Copy link

sourcery-ai bot commented Jul 31, 2024

Reviewer's Guide by Sourcery

This pull request enhances the login screen options by replacing the existing login and registration forms with a Bootstrap accordion structure. This change improves the user interface and user experience by organizing the forms into collapsible panels. Additionally, the login button text has been updated to 'Login as Attendee with Eventyay-Ticket' with a redirect URL.

File-Level Changes

Files Changes
src/pretalx/common/templates/common/auth.html Replaced the existing login and registration forms with a Bootstrap accordion structure, enhancing the user interface and user experience.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @odkhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider retaining some of the explanatory text (e.g., 'I already have an account', 'I need a new account') to help users understand the purpose of each section.
  • The hardcoded redirect in the Eventyay login URL (?next=/{{ request.event.slug }}/schedule/) might not be universally applicable. Consider handling redirects in the backend instead.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@mariobehling mariobehling merged commit b2b3f01 into fossasia:development Jul 31, 2024
3 of 9 checks passed
@it-tma-tri it-tma-tri mentioned this pull request Jul 31, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants