Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve export text and button #177

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

lcduong
Copy link
Contributor

@lcduong lcduong commented Aug 7, 2024

This PR closes/references issue #171 . It does so by

  • Update text for exporter
  • fix QR generate

How has this been tested?

Checklist

  • I have added tests to cover my changes.

Summary by Sourcery

Fix QR code generation and update text for various exporters and the 'Add to Calendar' button for improved clarity and user experience.

Bug Fixes:

  • Fix QR code generation to ensure proper creation and display of QR codes.

Enhancements:

  • Update verbose names for various exporters to more descriptive and user-friendly text.
  • Change the 'Add to Calendar' button icon and text for better clarity.

Copy link

sourcery-ai bot commented Aug 7, 2024

Reviewer's Guide by Sourcery

This pull request addresses issue #171 by updating the text for the exporter and fixing the QR code generation. The QR code generation logic in 'src/pretalx/common/exporter.py' has been revised to use a QRCode instance, and the image is now converted to a data URL. Additionally, the verbose_name attributes for various exporters in 'src/pretalx/schedule/exporters.py' have been updated to more user-friendly names. The button text and icon for adding events to the calendar in 'src/pretalx/agenda/templates/agenda/header_row.html' have also been changed.

File-Level Changes

Files Changes
src/pretalx/schedule/exporters.py Updated the verbose_name attributes for multiple exporters to improve clarity and user experience.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@lcduong
Copy link
Contributor Author

lcduong commented Aug 7, 2024

image

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lcduong - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding tests to cover the new QR code generation functionality to ensure its correctness and prevent future regressions.
  • It might be beneficial to profile the new QR code generation method to ensure it doesn't introduce any performance issues, especially if it's used frequently.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@mariobehling mariobehling merged commit e937b99 into fossasia:development Aug 7, 2024
3 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants