-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: docs not being built in gh-pages #263
Conversation
Reviewer's Guide by SourceryThis PR fixes the documentation deployment issue by updating the GitHub Actions deploy workflow. The branch trigger configuration was modified to listen to pushes on 'development' and 'main', and an extraneous comment regarding the Sphinx docs directory was removed for clarity. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @r3yc0n1c - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a wildcard for the branches if you want to include all branches.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Good job! It builds in the gh-pages branch. To do: Delete the CNAME in the dev branch. Automatically create the CNAME on deployment in the gh-pages branch. I added the CNAME manually for now. |
sure, I'll add it in the workflow itself |
fixes #256
ref PR #260
Summary by Sourcery
Update the GitHub Pages deployment workflow to build and deploy the documentation from the
main
anddevelopment
branches instead of thedeployment
branch.CI:
main
anddevelopment
branches.Documentation:
doc
directory.