Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docs not being built in gh-pages #263

Merged
merged 10 commits into from
Feb 11, 2025

Conversation

r3yc0n1c
Copy link
Contributor

@r3yc0n1c r3yc0n1c commented Feb 11, 2025

fixes #256

ref PR #260

Summary by Sourcery

Update the GitHub Pages deployment workflow to build and deploy the documentation from the main and development branches instead of the deployment branch.

CI:

  • Deploy documentation to GitHub Pages from the main and development branches.

Documentation:

  • Build the documentation in the doc directory.

Copy link

sourcery-ai bot commented Feb 11, 2025

Reviewer's Guide by Sourcery

This PR fixes the documentation deployment issue by updating the GitHub Actions deploy workflow. The branch trigger configuration was modified to listen to pushes on 'development' and 'main', and an extraneous comment regarding the Sphinx docs directory was removed for clarity.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Modify branch trigger configuration in the deploy workflow
  • Replaced the 'deployment' branch with an array [development, main] to ensure docs are built from the correct branches
.github/workflows/deploy.yml
Clean up working-directory configuration
  • Removed the note comment regarding the Sphinx docs directory from the working-directory specification
.github/workflows/deploy.yml

Assessment against linked issues

Issue Objective Addressed Explanation
#256 Create a GitHub Actions workflow to automatically deploy Sphinx documentation to the gh-pages branch
#256 Configure the workflow to build documentation from the correct directory
#256 Trigger documentation deployment on pushes to main and development branches

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @r3yc0n1c - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using a wildcard for the branches if you want to include all branches.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@mariobehling mariobehling merged commit 42aaf2e into fossasia:development Feb 11, 2025
6 of 8 checks passed
@mariobehling
Copy link
Member

Good job! It builds in the gh-pages branch.

To do: Delete the CNAME in the dev branch. Automatically create the CNAME on deployment in the gh-pages branch. I added the CNAME manually for now.

@r3yc0n1c
Copy link
Contributor Author

sure, I'll add it in the workflow itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy the documentation automatically to the branch gh-pages and Actions
2 participants