Enhance system messages #457
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis PR focuses on updating system messages and text throughout the application, primarily removing references to "pretix" in user-facing strings and plugin metadata. The changes are straightforward text modifications that make the system messaging more generic and brand-neutral. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @lcduong - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please improve the commit message to clearly explain the motivation and goals behind removing pretix branding and author attributions. This will help future maintainers understand why these changes were made.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| @@ -27,7 +27,7 @@ supports the following authorization schemes: | |||
| Permissions | |||
| ----------- | |||
|
|
|||
| The API follows pretix team based permissions model. Each organizer can have several teams | |||
| The API follows dev team based permissions model. Each organizer can have several teams | |||
| each with it's own set of permissions. Each team can have any number of API keys attached. | |||
There was a problem hiding this comment.
issue (typo): Grammatical error: 'it's' should be 'its' as this is the possessive form
| @@ -72,7 +72,7 @@ A working example would be: | |||
|
|
|||
| class PretixPluginMeta: | |||
| name = _("PayPal") | |||
| author = _("the pretix team") | |||
| author = _("the development team") | |||
| @@ -53,7 +53,7 @@ The alternative approach that is included with pretix is to choose a signature-b | |||
| These secrets include the most important information that is required for verifying their validity and use modern | |||
| cryptography to make sure they cannot be forged. | |||
|
|
|||
| Currently, pretix ships with one such scheme ("pretix signature scheme 1") which encodes the product, the product | |||
| Currently, pretix ships with one such scheme ("signature scheme 1") which encodes the product, the product | |||
There was a problem hiding this comment.
Currently, the platform ships with one such scheme ("signature scheme 1") which encodes the product, the product
| @@ -283,7 +283,7 @@ def checkin_widget(sender, subevent=None, lazy=False, **kwargs): | |||
| def welcome_wizard_widget(sender, **kwargs): | |||
| template = get_template('pretixcontrol/event/dashboard_widget_welcome.html') | |||
| ctx = { | |||
| 'title': _('Welcome to pretix!') | |||
| 'title': _('Welcome') | |||
| @@ -12333,7 +12333,7 @@ msgstr "ميزات أخرى" | |||
| #| "%(url)s\n" | |||
| #| "\n" | |||
| #| "Best regards,\n" | |||
| #| "Your pretix team\n" | |||
| #| "Your development team\n" | |||
| @@ -12373,7 +12373,7 @@ msgstr "" | |||
| #| "\n" | |||
| #| "Best regards,\n" | |||
| #| "\n" | |||
| #| "Your pretix team\n" | |||
| #| "Your development team\n" | |||
| @@ -12426,7 +12426,7 @@ msgstr "" | |||
| #| "%(url)s\n" | |||
| #| "\n" | |||
| #| "Best regards,\n" | |||
| #| "Your pretix team\n" | |||
| #| "Your development team\n" | |||
| @@ -19267,7 +19267,7 @@ msgstr "شارات" | |||
| #: pretix/plugins/statistics/apps.py:13 | |||
| #: pretix/plugins/ticketoutputpdf/apps.py:14 | |||
| #: pretix/plugins/webcheckin/apps.py:13 | |||
| msgid "the pretix team" | |||
| msgid "the development team" | |||
| @@ -12203,7 +12203,7 @@ msgstr "Altres característiques" | |||
| #| "%(url)s\n" | |||
| #| "\n" | |||
| #| "Best regards,\n" | |||
| #| "Your pretix team\n" | |||
| #| "Your development team\n" | |||
| @@ -12243,7 +12243,7 @@ msgstr "" | |||
| #| "\n" | |||
| #| "Best regards,\n" | |||
| #| "\n" | |||
| #| "Your pretix team\n" | |||
| #| "Your development team\n" | |||
| @@ -18592,7 +18592,7 @@ msgstr "Targes d'identificació" | |||
| #: pretix/plugins/statistics/apps.py:13 | |||
| #: pretix/plugins/ticketoutputpdf/apps.py:14 | |||
| #: pretix/plugins/webcheckin/apps.py:13 | |||
| msgid "the pretix team" | |||
| msgid "the development team" | |||
| @@ -11,7 +11,6 @@ class PaypalApp(AppConfig): | |||
|
|
|||
| class PretixPluginMeta: | |||
| name = _("PayPal") | |||
There was a problem hiding this comment.
author = _("eventyay team")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR resolves #441
Changing messages of tickets system.
Note: there' re still package name with pretix, as it got impact all codes so I'm not changing it in this PR.
Summary by Sourcery
Enhancements: