-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eventyay-Common: Create Dropdown menu similar to the "Tickets" component #464
Draft
odkhang
wants to merge
4
commits into
fossasia:development
Choose a base branch
from
odkhang:create-dropdown-menu-for-eventyay-common
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Eventyay-Common: Create Dropdown menu similar to the "Tickets" component #464
odkhang
wants to merge
4
commits into
fossasia:development
from
odkhang:create-dropdown-menu-for-eventyay-common
+308
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis PR implements a dropdown menu component similar to the "Tickets" component, featuring a user profile menu with nested submenus. The implementation includes styling updates, new JavaScript functionality for menu interactions, and backend changes to support the new account settings feature. Sequence diagram for the profile menu interactionsequenceDiagram
actor User
participant Webpage
participant Dropdown
participant Submenu
User->>Webpage: Click on profile icon
Webpage->>Dropdown: Show profile menu
User->>Dropdown: Hover over "Dashboard"
Dropdown->>Submenu: Display submenu
User->>Submenu: Click on "Tickets"
Submenu->>User: Redirect to Tickets page
Updated class diagram for the UserSettings viewclassDiagram
class UserSettings {
+get_object(queryset)
+get_form_kwargs()
+form_invalid(form)
+form_valid(form)
+get_success_url()
}
class User {
+send_security_notice(msgs, email)
+log_action(action, user, data)
}
UserSettings --> User
note for UserSettings "Handles user account settings update logic"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolved #442
Summary by Sourcery
Implement a dropdown menu similar to the 'Tickets' component, enhancing the navigation experience with a new submenu. Add an 'Account' section to the global navigation and introduce a popover feature for the profile menu. Create a new account settings page template for user settings management.
New Features:
Enhancements:
Documentation: